https://bugzilla.redhat.com/show_bug.cgi?id=1060502
--- Comment #4 from Lubomir Rintel lkundrak@v3.sk --- The above review makes sense. Just some random extra things I've verified manually:
* Package is named correctly * The version tag makes sense * License tag is correct * License is fine * License text included * rpmlint is happy * SPEC file is clean and legible
Nothing severe really stands out; basically a couple of style issues:
0.) The description is a bit weird: Please do not repeat the summary and omit the hyperlinks.
%description This (cli) is the library for implementing powerful command-line interfaces in Go. It's used by Self and Packer.
%description devel This package contains the library for implementing powerful command-line interfaces in Go. It's intended for building other packages which use these functions.
1.) Please move BuildRequires ourside %package section.
2.) The package should always be noarch.
It only ships architecture-independent files. See [1]
[1] https://fedoraproject.org/wiki/Packaging:Guidelines#Noarch_with_unported_dep...
-%if 0%{?fedora} >= 19 || 0%{?rhel} >= 7 -BuildArch: noarch -%else -ExclusiveArch: %{ix86} x86_64 %{arm} -%endif +BuildArch: noarch +%if 0%{?fedora} < 19 && 0%{?rhel} < 7 +ExclusiveArch: %{ix86} x86_64 %{arm} noarch +%endif
3.) No need for the %attr macro; install files with correct mode in %install. You won't need to list the whole hierarchy too.
-%dir %attr(755,root,root) %{gopath} -%dir %attr(755,root,root) %{gopath}/src -%dir %attr(755,root,root) %{gopath}/src/github.com -%dir %attr(755,root,root) %{gopath}/src/github.com/mitchellh -%dir %attr(755,root,root) %{gopath}/src/%{import_path} -%attr(644,root,root) %{gopath}/src/%{import_path}/*.go +%{gopath}