https://bugzilla.redhat.com/show_bug.cgi?id=833855
--- Comment #2 from Jef Spaleta <jspaleta(a)gmail.com> ---
Summary:
Fix items 1 and 2 below and I'll be able to accept it.
Items that need to be addressed:
1) License field needs to be updated to read
GPLv2+ and MIT and Public Domain due to license on the setupcon script.
This is a blocker
2) No need to for the package to own /etc/default
/etc/default is owned by glibc which is part of the requirement chain through
the requirement on the kdb package. All other directory ownership looks good.
This is a blocker
Other items
3) rpmlint against the rpm has one E associated with incorrect FSF address from
the ckbcomp utility boilerplate. You are encouraged to notify the upstream for
this package to fix it, and you can correct it with a patch in your
package..but are not required to do so.
4) The supplied manpages still refer to /usr/local/etc/default instead of
/etc/default/ in multiple place. See if you can enhance the paths patch to fix
that.
5) I dont understand the notes in the spec concerning xkeyboard-config as a
possible requirement. Can you explain to me what the problem is in a little
more detail? Not a blocker, but I don't have enough info to make a
recomendation.
6)
setupcon -v gives me some interesting feedback concerning keymap deny errors
for the loadkeys operation which suggests to me that the loadkeys operation its
not working as expected. Not sure what's going on there..but its not falling
over with a crash condition. You want to sort this out as part of this review?
I can supply the output on my F16 system.
Other Must checklist items:
rpmlint: console-setup-1.76-1.fc16.noarch.rpm
console-setup.noarch: W: spelling-error Summary(en_US) keymaps -> key maps,
key-maps, makeups
console-setup.noarch: E: incorrect-fsf-address /usr/bin/ckbcomp
source checksum verifies
upstream checksum is:
38cbc433c40d80f164097e7acaf57b3e console-setup_1.76.tar.gz
applied patch to fix up file paths seems reasonable. There might be a more
clever way to do that patch, but that's not a blocker for inclusion.
package naming looks good according to guidelines.
Compiles cleanly on F16 and against koji scratch build
no locale files
no libraries
no devel files
no large docs
docs looks good
spec file is legible and has consistent use of macros.
setupcon appears to run without faulting on a console tty
--
You are receiving this mail because:
You are on the CC list for the bug.