https://bugzilla.redhat.com/show_bug.cgi?id=1055391
Jerry James loganjerry@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #5 from Jerry James loganjerry@gmail.com --- (In reply to Michel Alexandre Salim from comment #4)
Aha, thanks! As it turns out the debug_package nullification is still needed when ocamlopt is not present (tested by overriding opt to 0) so I've if-guarded it.
Hmmm, that's a good point. I don't think that was done during the mass enabling of debuginfo for ocaml packages. Maybe we don't currently have any architectures that support byte-code-only ocaml, so nobody has noticed?
That line works, thanks. As for the dependency generator, wow, someone needs to update those templates.
Agreed. I'll see if I can poke somebody to do that.
You handled all of the issues I brought up, and a re-review did not turn up any new issues, so this package is APPROVED.