https://bugzilla.redhat.com/show_bug.cgi?id=2116088
Fabio Valentini <decathorpe(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |decathorpe(a)gmail.com
Doc Type|--- |If docs needed, set a value
Flags| |fedora-review?
Assignee|nobody(a)fedoraproject.org |decathorpe(a)gmail.com
Status|NEW |ASSIGNED
--- Comment #1 from Fabio Valentini <decathorpe(a)gmail.com> ---
There's some issues with the current version of this package:
1. upstream project does not include license files
You should file a PR with upstream to include LICENSE-APACHE and LICENSE-MIT
files.
Additionally, the link to the MIT license that you used points at an HTML page,
not a plaintext version.
Please attempt to resolve this with upstream (i.e. "Copyright <YEAR>
<COPYRIGHT
HOLDER>" placeholder text also needs to be resolved somehow).
I suspect the resolution will be similar to the one in the package for
strength_reduce, given that it's the same upstream developer ...
2. drop criterion dependency entirely
The "criterion" library is only used in benchmark code. It is safe to remove it
entirely from Fedora packages, since we neither build nor run benchmark code.
Keeping the dependency usually just inflates the dependency tree and package
build times by a huuuuuuge amount.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2116088