Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492715
--- Comment #31 from Zarko (grof) zarko.pintar@gmail.com 2009-06-02 03:32:06 EDT --- Let's do some cosmetics:
1) Move out these and correct other spec code to works without these definitions: ------------------------------- #define rel snapshot-2009-05-31-r889 #define rel2 0.12.r889.20090531 %define rel %{version} %define rel2 1 -------------------------------- *
2) Comment included %patch0 and %source1 files!
3) %setup line can be: %setup -q -a 1
4) %cmake can be: %cmake_kde4
5) after removing %define lines you must change:
cp -R %{_builddir}/%{name}-%{rel}/html/* \ to cp -R %{_builddir}/%{name}-%{version}/html/* \
6) .desktop file do not contain mimetype key, so we can now remove these lines from %post and %postun:
update-desktop-database &> /dev/null || :
(This is my mistake ;) )
7) Maybe the most important thing!
Are you sure that we can make package for internet radio as a nonfree package, and just install them to Kradio works properly, without need to rebuild (compile) Kradio4 with needed BR: -devel packages???
Because, if we must build Kradio4 package with nonfree -devel dependencies, than Kradio4 must fo to RPM Fusion for full functionality.
I ask because I saw that builder, at configure time ask for these nonfree devel dependencies...
Can you chack this on some way?