Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=564567
--- Comment #2 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-02-13 13:38:09 EST --- Well, I want to go to bed for now, however some brief notes:
- On rawhide your package does not build as below. http://koji.fedoraproject.org/koji/taskinfo?taskID=1983436 This is because Fedora 13 changed the behavior of linker: http://fedoraproject.org/wiki/UnderstandingDSOLinkChange
To check F-13 linker behavior on F-12/11, you can do this by adding ------------------------------------------------------------- export LDFLAGS="-Wl,--no-add-needed" ------------------------------------------------------------- before %configure line.
Then some other notes - "Requires: cjkuni-ukai-fonts" is not desired. On Fedora cjkuni-XXXX is the default font for Chinese but not for Japanese. On Fedora Japanese people use "vlgothic-fonts" rpm for fonts by default.
- Your spec file contains: ------------------------------------------------------------- #%configure --disable-schemas %configure --disable-schemas-install ------------------------------------------------------------- With this build log will show (actually https://koji.fedoraproject.org/koji/taskinfo?taskID=1983466 shows) that configure is executed twice, not once. This is because rpmbuild will expand macros (in this case %configure) anyway even if the line is marked as a comment.
To prevent this, you should use #%%configure so that macros won't be expanded in comment lines.
- Please consider to use ------------------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ------------------------------------------------------------- to keep timestamps on installed files as much as possible. This method usually works for Makefiles generated by recent autotools.
- Currently documents are installed both under - /usr/share/doc/gwaei - /usr/shaer/doc/gwaei-1.2.1 Please unify these directories.
- I have not checked this package in details, however usually the file "ABOUT-NLS" is unuseful.
- Files/directories under %{_datadir}/doc/ are automatically marked as %doc.
- rpmlint may complain, however we usually don't regard gconf schemas files as config files so please remove %config from gconf schemas file.