https://bugzilla.redhat.com/show_bug.cgi?id=2032487
--- Comment #8 from Christoph Junghans <junghans(a)votca.org> ---
(In reply to Susi Lehtola from comment #7)
- the bash file is installed in the wrong directory. The correct one
is
%{_datadir}/bash-completion/completions/ which is owned by filesystem
Done
- please use a trailing / consistently to mark directories, e.g.
%{_datadir}/votca/csg-tutorials/
vs
%{_datadir}/votca/xtp
Slash added everywhere
- changelog is empty
Added
- please move the %global definitions to the top of the spec file.
Also,
don't indent them; the syntax differs from the other field and the
indentation thereby leads one astray as the indented data is not the value
but the key!
Moved.
- suffix should be defined in man1 files,
%{_mandir}/man1/{votca,csg,xtp}_*.1*
Changed
- interdependencies should be fully versioned
Added
- please check what's up with the duplicate files
Ran
%{fdupes} on it.
[!]: Changelog in prescribed format.
Note: no changelog!!
Done
[!]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in votca-
devel , votca-libs , votca-common , votca-csg-tutorials , votca-xtp-
tutorials , votca-common-xtp , votca-bash
Added.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2032487