https://bugzilla.redhat.com/show_bug.cgi?id=1726843
--- Comment #3 from Miro Hrončok mhroncok@redhat.com --- Various notes about the spec:
Requires: python3-box Requires: python3-click Requires: python3-dotenv Requires: python3-toml Requires: python3-pyyaml
Is the automatic dependency generator not useful here?
---
%{python3_sitelib}/%{srcname}-*.egg-info
The setup.py has:
try: from setuptools import setup, find_packages except ImportError: from distutils.core import setup, find_packages
I consider this combination quite dangerous, because based on the presence of setuptools in the buildroot, either distutils or setuptools will be used and %{python3_sitelib}/%{srcname}-*.egg-info will either be a file or directory. Updates between those two are problematic, see https://docs.fedoraproject.org/en-US/packaging-guidelines/Directory_Replacem...
As a precaution I suggest doing the following:
1) BuildRequire python3-setuptools explicitly 2) add a trailing slash to %{python3_sitelib}/%{srcname}-*.egg-info/ -> this will make sure the build fails if it is not a directory 3) (optional) also add the slash to %{python3_sitelib}/%{srcname}/ for consistency with 2) and better readability
---
Summary: dynaconf is a dynamic configurator for python projects -> Summary: Dynaconf is a dynamic configurator for Python projects
---
%global common_desc \ dynaconf is a layered configuration system for Python applications with strong \ support for 12-factor applications and extensions for Flask and Django -> %global common_desc \ Dynaconf is a layered configuration system for Python applications with strong \ support for 12-factor applications and extensions for Flask and Django.