https://bugzilla.redhat.com/show_bug.cgi?id=1259002
Kevin Fenzi kevin@scrye.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |kevin@scrye.com Flags| |fedora-review?
--- Comment #11 from Kevin Fenzi kevin@scrye.com --- So, you don't really need to mention the test and build scripts licenses. You want to list the license of the files in the binary packages. https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#Does_the_Licen...
There's no need to change license version, LGPLv2 is fine, you just want to update the LGPLv2 COPYING file (they updated it when the fsf moved mailing addresses).
One other minor thing I noticed from a prelim bit of testing:
rudiments.x86_64: W: unused-direct-shlib-dependency /usr/lib64/librudiments-0.53.so.1.0.0 /lib64/libm.so.6
perhaps you don't need to link -lm?
I'll go ahead and take this for review now, look for a full review a bit later hopefully today. ;)