Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xorg-x11-drv-suncg3 - x driver for suncg3 hardware
https://bugzilla.redhat.com/show_bug.cgi?id=448559
bdpepple@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |bdpepple@gmail.com Status|NEW |ASSIGNED Flag| |fedora-review+
------- Additional Comments From bdpepple@gmail.com 2008-06-03 21:34 EST ------- MD5Sum: b9cb8cfb6a4234bebc434f744af53208 xf86-video-suncg3-1.1.0.tar.bz2
Good: Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Buildroot has all required elements * All paths begin with macros * All necessary BuildRequires listed. * Make succeeds even when %{_smp_mflags} is defined * Files have appropriate permissions and owners
Bad: * rpmlint produces the following error: xorg-x11-drv-suncg3.sparc64: W: invalid-license MIT/X11
Looking at the license matrix, it looks like it should just be MIT. You can fix this when you import this into CVS.
Note: I don't have the hardware to verify that this driver works, but from a packaging standpoint this package looks fine.
+1 APPROVE.