Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=732758
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #4 from Petr Pisar ppisar@redhat.com 2011-08-24 09:37:09 EDT --- Spec file changes:
--- perl-SOAP-Transport-TCP.spec 2011-08-23 16:05:08.000000000 +0200 +++ perl-SOAP-Transport-TCP.spec.1 2011-08-24 14:48:50.000000000 +0200 @@ -3,9 +3,9 @@
Name: perl-SOAP-Transport-TCP Version: 0.715 -Release: 1%{?dist} -Summary: SOAP::Transport::TCP Perl module -License: Artistic +Release: 2%{?dist} +Summary: TCP Transport Support for SOAP::Lite +License: GPL+ or Artistic Group: Development/Libraries URL: http://search.cpan.org/dist/SOAP-Transport-TCP/ Source0: http://www.cpan.org/authors/id/M/MK/MKUTTER/SOAP-Transport-TCP-%%7Bversion%7... @@ -21,11 +21,14 @@ BuildRequires: perl(IO::Socket) BuildRequires: perl(SOAP::Lite) >= 0.714 BuildRequires: perl(URI) +BuildRequires: perl(URI::_server) BuildRequires: perl(Test::More) %endif Requires: perl(SOAP::Lite) >= 0.714 Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+%global __requires_exclude %{?__requires_exclude:%__requires_exclude|}perl\(SOAP::Lite\)$ + %description The classes provided by this module implement direct TCP/IP communications methods for both clients and servers. @@ -54,5 +57,8 @@ %{_mandir}/man3/*
%changelog +* Wed Aug 24 2011 Petr Sabata contyk@redhat.com - 0.715-2 +- Correcting various defects for the review + * Tue Aug 23 2011 Petr Sabata contyk@redhat.com 0.715-1 - Initial RPM
TODO: Change summary to wording used in POD: `TCP Transport Support for SOAP::Lite'. Current one just repeat Perl module name which is noting new from package name or list of files.
-Release: 1%{?dist} -Summary: SOAP::Transport::TCP Perl module -License: Artistic +Release: 2%{?dist} +Summary: TCP Transport Support for SOAP::Lite +License: GPL+ or Artistic Ok.
FIX: Change license to `GPL+ or Artistic' as lib/SOAP/Transport/TCP.pm says:
This library is free software; you can redistribute it and/or modify it under the same terms as Perl itself.
-Release: 1%{?dist} -Summary: SOAP::Transport::TCP Perl module -License: Artistic +Release: 2%{?dist} +Summary: TCP Transport Support for SOAP::Lite +License: GPL+ or Artistic Ok.
FIX: BuildRequire (conditionally) perl(URI::_server) (lib/SOAP/Transport/TCP.pm:28) to proceed tests.
+BuildRequires: perl(URI::_server) Ok.
TODO: Remove underspecified perl(SOAP::Lite) from Requires.
+%global __requires_exclude %{?__requires_exclude:%__requires_exclude|}perl\(SOAP::Lite\)$ + $ rpm -q --requires -p ../RPMS/noarch/perl-SOAP-Transport-TCP-0.715-2.fc17.noarch.rpm |sort |uniq -c 1 perl(Carp) 1 perl(IO::Select) 1 perl(IO::SessionData) 1 perl(IO::SessionSet) 1 perl(IO::Socket) 1 perl(:MODULE_COMPAT_5.14.1) 1 perl(SOAP::Lite) >= 0.714 1 perl(strict) 1 perl(URI) 1 perl(URI::_server) 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Ok.
$ rpmlint perl-SOAP-Transport-TCP.spec ../SRPMS/perl-SOAP-Transport-TCP-0.715-2.fc15.src.rpm ../RPMS/noarch/perl-SOAP-Transport-TCP-0.715-2.fc15.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint Ok.
Package builds in F17 (http://koji.fedoraproject.org/koji/taskinfo?taskID=3298182). ???
Package is in line with Fedora and Perl packaging guidelines.
Resolution: Package APPROVED.