https://bugzilla.redhat.com/show_bug.cgi?id=1122244
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #1 from Parag AN(पराग) panemade@gmail.com --- Review:
+ mock build is successful for f22.
+ rpmlint output on rpms gave nodejs-superagent-proxy.noarch: W: spelling-error Summary(en_US) uri -> uric, Yuri, urn nodejs-superagent-proxy.noarch: W: spelling-error %description -l en_US visionmedia -> vision media, vision-media, divisional nodejs-superagent-proxy.noarch: W: spelling-error %description -l en_US uri -> uric, Yuri, urn nodejs-superagent-proxy.noarch: W: only-non-binary-in-usr-lib nodejs-superagent-proxy.noarch: W: dangling-symlink /usr/lib/node_modules/superagent-proxy/node_modules/proxy-agent /usr/lib/node_modules/proxy-agent nodejs-superagent-proxy.noarch: W: dangling-symlink /usr/lib/node_modules/superagent-proxy/node_modules/debug /usr/lib/node_modules/debug nodejs-superagent-proxy.src: W: spelling-error Summary(en_US) uri -> uric, Yuri, urn nodejs-superagent-proxy.src: W: spelling-error %description -l en_US visionmedia -> vision media, vision-media, divisional nodejs-superagent-proxy.src: W: spelling-error %description -l en_US uri -> uric, Yuri, urn 2 packages and 0 specfiles checked; 0 errors, 9 warnings.
+ Source verified with upstream as (sha256sum) srpm tarball :c17fdcefbab6e6fb59cf71de9a748032685a14bfc7dd9d7321f88d915c0bb746 upstream tarball :c17fdcefbab6e6fb59cf71de9a748032685a14bfc7dd9d7321f88d915c0bb746
+ License "MIT" is valid and is included in README.md file as %doc
+ rest looks following packaging guidelines.
Suggestions: 1) Explicit requires should be dropped as they are already pulled by rpm while resolving dependencies.
APPROVED.