Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=495902
--- Comment #2 from Paul Fox pgf@laptop.org 2009-05-02 19:34:42 EDT --- (In reply to comment #1)
Just some quick comments on your spec file.
thanks!
- The license is GPLv2+ (see source header, 'either version 2 of the License,
or
- (at your option) any later version.') not GPLv2
yup.
- 'Release: 1' should be 'Release: 1%{?dist}'
okay. i can't find a reference for %{dist}. when is it set?
- 'Source0' should point to the upstream location of the source tarball if
there won't normally be an upstream tarball location. the srpm comes from the same place the tarball would -- i.e., git. so i commented Source0 as in: https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control is that okay?
- There is 'gcc' mentioned in the 'BuildRequires' this is not needed https://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2
okay.
- Please replace 'BuildArch' with 'ExcludeArch' https://fedoraproject.org/wiki/Architectures#ExcludeArch_.26_ExclusiveArch
i suppose. but this package really is intended just for the XO laptop -- it specifically supports the "Grab" keys on the XO keyboard, and handles rotation of the touchpad and local bezel-mounted arrow pad when the XO "rotate" button is used. i didn't see a point in building for non-i386 platforms. should i simply remove the BuildArch line? i confess i won't be much interested in fixing build problems for architectures on which this will never run.
- 'Provides: olpc-kbdshim = 4' is not needed https://fedoraproject.org/wiki/How_to_create_an_RPM_package#Other_tags
okay
- README is missing in %doc
yup.
- You must use macros in the %files section https://fedoraproject.org/wiki/Packaging:Guidelines#Macros
oops. rpmlint told me about libdir, but it didn't occur to me to look for the others.
what's the next step? after fixing, do i build new rpms for you (or someone else) to look at? or would just a spec file be enough?
-paul