Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836368
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@redhat.com
--- Comment #12 from Vít Ondruch vondruch@redhat.com --- A few minor nits from my side:
* Run test suite in %{gem_instdir} - We typically run test suite inside %{gem_instdir}, but it should not be of much importance here
* Keep the Gemfile*, Rakefile and tests - I would suggest yout to keep the abovementioned files in -doc subpackage. Although they make not much sense in the Gem, I would keep them in Fedoras packages, since upstream ships them. Or on the contrary, ask upstream to remove them from the package.
* Don't mark Rakefile by %doc macro - Rakefile is definitely not a document and should not be prepended by %doc macro