Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=642592
--- Comment #3 from Jozef Zigmund jzigmund@redhat.com 2010-10-26 12:59:50 EDT --- This review it's just NONFORMAL because i'm not in Fedora Packager Group right now.
rpmlint rubygem-macaddr-1.0.0-1.fc13.src.rpm rubygem-macaddr.src: W: no-buildroot-tag rubygem-macaddr.src:35: W: mixed-use-of-spaces-and-tabs (spaces: line 35, tab: line 16) 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
[BAD - in spec-file at line 15 is empty row and at line 16 is abundant tab character]
MUST: The License field in the package spec file must match the actual license.
License: GPLv2+ or Ruby
[OK? - gem doesn't contain LICENSE]
Each Ruby package MUST indicate the Ruby ABI version it depends on with a line like: Requires: ruby(abi) = 1.8
[OK - this MUST condition is written via macro in this spec file]
Packages that contain Ruby Gems MUST be called rubygem-%{gemname} where gemname is the name from the Gem's specification.
%global gemname macaddr Name: rubygem-%{gemname}
[OK]
The Source of the package MUST be the full URL to the released Gem archive
URL: http://codeforpeople.com/lib/ruby/macaddr/ Source0: http://gems.rubyforge.org/gems/%%7Bgemname%7D-%%7Bversion%7D.gem
[OK]
The version of the package MUST be the Gem's version
Version: 1.0.0
[OK]
The package MUST have a Requires and a BuildRequires on rubygems
%global rubyabi 1.8
Requires: ruby(abi) = %{rubyabi} Requires: rubygems >= 0 Requires: ruby >= 0 BuildRequires: rubygems >= 0 BuildRequires: ruby >= 0
[BAD - need remove tab character at line 16, and checking againt zero version is not needed]
The Gem MUST be installed into %{gemdir} defined as: %global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null)
[OK]
If the Gem only contains pure Ruby code, it MUST be marked as BuildArch: noarch
[OK]
The package MUST own the following files and directories:
%{gemdir}/gems/%{gemname}-%{version}/ %{gemdir}/cache/%{gemname}-%{version}.gem %{gemdir}/specifications/%{gemname}-%{version}.gemspec
[OK? - it doesn't contain directory gems, but i think that in this case it isn't necessary]
The install SHOULD be performed with the command
gem install --local --install-dir %{buildroot}%{gemdir} --force %{SOURCE0}
[OK]