https://bugzilla.redhat.com/show_bug.cgi?id=2040728
Artur Frenszek-Iwicki fedora@svgames.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |fedora@svgames.pl
--- Comment #2 from Artur Frenszek-Iwicki fedora@svgames.pl ---
BuildRoot: %{_tmppath}/%{name}-root
Not used in Fedora.
%install rm -rf $RPM_BUILD_ROOT/*
Don't. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_section...
BuildRequires: gcc, gcc-c++, cmake >= 2.4.7, pkgconfig, gtk2-devel BuildRequires: libzip, libzip-devel, pandoc, desktop-file-utils BuildRequires: gettext, gettext-devel, glibc-devel
It's a matter of style, and hence - subjective - but I'd reformat this to put each dependency on a separate line.
Similarly with the %install section - you can put empty lines between the commands, it'll work fine.
BuildRequires: libzip, libzip-devel BuildRequires: gettext, gettext-devel
Requiring the base packages is not needed; -devel packages are required to pull in the base package as a direct dependency. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_p...
cmake -D CMAKE_INSTALL_PREFIX:PATH=%{_prefix} -D CMAKE_BUILD_TYPE=Debug . %make_build
Can you try doing "%cmake" and then "%cmake_build"?
make DESTDIR=$RPM_BUILD_ROOT install
Same here - try using "%cmake_install". https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/
mv %{buildroot}/%{_datadir}/%{name}/pixmaps/xtrkcad.png %{buildroot}/%{_datadir}/icons
I believe this should go into either "%{buildroot}%{_datadir}/pixmaps", or into "%{buildroot}%{_datadir}/icons/hicolor/SIZE/apps/". The latter also mandates adding "Requires: hicolor-icon-theme".