https://bugzilla.redhat.com/show_bug.cgi?id=1037900
František Dvořák valtri@civ.zcu.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |valtri@civ.zcu.cz
--- Comment #3 from František Dvořák valtri@civ.zcu.cz --- Trying a review... (although unexperienced, I don't have any ruby package yet)
Found only cosmetics (nothing needs to be changed):
1) For downloading sources you can consider client that preserves the upstream timestamps:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=PackagingGuidelines#T...
2) Why is the '%exclude %{gem_instdir}/test' in -doc subpackage? But there is probably no reason why not.
Remarks:
* You're patching out development files in %prep. It is true it may be better than using %exclude in %files, right? (Files won't be installed, they won't be there during testing...).
* %check section: It looks like redis-server listens only on IPv4 and communication during testing goes through 127.0.0.1. But it works well in koji and even on IPv6-only machine.
Would you agree for review swap with rubygem-json_spec (#1079640)? But I can do formal review here anyway. :-)
Thank you, František