Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=593800
--- Comment #54 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-11-28 07:22:45 EST --- (In reply to comment #53)
(In reply to comment #52)
Well,
at least new python-keyring binary rpm must have "Obsoletes: %{name}-gnome < 0.5", "Obsoletes: %{name}-kwallet < 0.5" and "Obsoletes: %{name}-debuginfo < 0.5" (because of arch-dependent -> noarch switch).
Currently I don't think we should add "Requires: PyKDE4 PyQt4" for functionality on KDE, and we don't have to add "Provides: %{name}-gnome =
foo"
Actually the latest python keyring code imports PyKDE4 and PyQt4 modules.
- If they exist, otherwise keyring/backend.py won't use them. So people who wants to use KDE support can install them afterwards. Forcing people to install PyKDE4 or PyQt4 even for GNOME user when wanting to use python-keyring is not a good idea.
So I think there should be "Requires: PyKDE4 PyQt4"
Also, is it necessary to keep the gnome and KDE subpackages with the new package?
- So: - If you want to remove -gnome / -kwallet subpackage (because they have no files any longer), - As I said before "Obsoletes: foo" is needed, and "Requires: PyKDE4" or so should be removed - If you want to leave -gnome / -kwallet subpackages (even if they are empty), I don't oppose to it, however I prefer to remove these subpackages.