https://bugzilla.redhat.com/show_bug.cgi?id=2010999
Michael Catanzaro mcatanza@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mcatanza@redhat.com
--- Comment #1 from Michael Catanzaro mcatanza@redhat.com --- This is not a full review, but a preliminary one:
Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/help/C/gnome-text-editor But I think this is a bug in fedora-review, since this is a directory, not a file. So... I think you can ignore this one. - I think all four of the runtime Requires are unnecessary. These should all be handled automatically via autogenerated .so deps. - I've never understood the directory ownership rules. Maybe we have to own or require other packages to own these dirs? Note: Directories without known owners: /usr/share/help/C, /usr/share/dbus-1, /usr/share/dbus-1/services