https://bugzilla.redhat.com/show_bug.cgi?id=1251034
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #4 from Shawn Iwinski shawn.iwinski@gmail.com --- [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [!]: Buildroot is not present Note: Buildroot: present but not needed [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required
As usual, remove EPEL 5 bits after initial import.
[x]: Requires correct, justified where necessary.
If EPEL-6 is in the target dists for this package need to replace build require "php-composer(phpunit/phpunit)" with either "%{_bindir}/phpunit" or php-phpunit-PHPUnit.
No blockers.
===== APPROVED =====