https://bugzilla.redhat.com/show_bug.cgi?id=1965529
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review?
--- Comment #1 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - Please use a more explicit name for the archive:
Source0: https://github.com/icecc/icemon/archive/v%%7Bversion%7D/%%7Bname%7D-%%7Bvers...
- Please justify the patch or link to an upstream PR/commit:
# Backport of docbook -> asciidoc from upstream # https://github.com/icecc/icemon/commit/479490ffbe0d13ed3059b67241671cb78521a... Patch1: icemon-asciidoc.patch
- The SPEC must be updated to the latest CMake guidelines, see https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/
%build %cmake %mcake_build
%install %cmake_install
[…]
%check %ctest
- Use https:
URL: https://kfunk.org/tag/icemon/
- End your description with a period;
%description A GUI monitor for Icecream, a distributed compiler system.
- The manpage should not be installed with %doc, and the manpage extension should be globbed as the compression may change in the future:
%{_mandir}/man1/icemon.1.*
- This could be simplified:
%{_datadir}/icons/hicolor/22x22/apps/icemon.png %{_datadir}/icons/hicolor/16x16/apps/icemon.png %{_datadir}/icons/hicolor/48x48/apps/icemon.png %{_datadir}/icons/hicolor/128x128/apps/icemon.png %{_datadir}/icons/hicolor/32x32/apps/icemon.png
→
%{_datadir}/icons/hicolor/*/apps/icemon.png
- Consider providing an Appdata file and validate it: https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/
- Add CHANGELOG.md and README.md to the %doc
%doc CHANGELOG.md README.md