https://bugzilla.redhat.com/show_bug.cgi?id=2235550
--- Comment #3 from Neal Gompa ngompa13@gmail.com --- Initial spec review:
License: BSD
This is no longer valid, we need it to be a valid SPDX license
Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline...
We don't seem to have a license text to go with this, and neither does kf5 (which it was forked from).
We should be able to go ahead and put in a BSD-3-Clause license file in both projects and just set this to BSD-3-Clause, though.
%if 0%{?fedora} || 0%{?rhel} > 7 Requires: cmake >= 3 Requires: qt6-rpm-macros >= 6 %else Requires: cmake3 Requires: qt6-qtbase-devel >= 6 %endif
We are not building this for anything older than EPEL 9, so we can simplify this logic to:
Requires: cmake >= 3 Requires: qt6-rpm-macros >= 6
%if 0%{?rhel} == 8 # This is where cmake-related macros live, e.g. %%cmake_build, %%cmake_install # at least until fixed upstream, https://bugzilla.redhat.com/show_bug.cgi?id=1858941 Requires: epel-rpm-macros %endif
This can be dropped. This was fixed a long time ago. Same for in EPEL 8.
%if 0%{?rhel} && 0%{?rhel} < 8 -e 's|%{__cmake}|%{__cmake3}|' \ %endif
This can be dropped.