https://bugzilla.redhat.com/show_bug.cgi?id=1776669
--- Comment #4 from Kevin Fenzi kevin@scrye.com --- (In reply to Miro Hrončok from comment #1)
Quick eyes only check:
- please add %python_provide:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ #_the_python_provide_macro
Done.
- you can use %pypi_source in Source0:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ #_source_files_from_pypi
Done.
- Obsoletes: pycdio < 2.0.0-5 -- maybe it should be < 2.0.0-6? I see
2.0.0-5.fc31 in Fedora 31
Done.
- Requires: python3 is redundant
Removed.
- %{python3_sitearch}/* should not be used
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ #_files_to_include
Fixed.
Will run automated checks on the next spec iteration.
ok
(In reply to Neal Gompa from comment #2)
If we want this in EPEL, you'll probably want to replace "python3-" with "python%{python3_pkgversion}-" so that it'll seamlessly work across EPEL releases.
The epel7 version is likely to be very different as it needs to support python2 (at least until koji moves to python3 there, which will likely not be a while). This spec works fine for epel8. I have no plans for epel6 support.
(In reply to Neal Gompa from comment #3)
Also, use either the %python3 or %__python3 macros for calling the interpreter directly, because we don't always have a /usr/bin/python3 for Python 3 across EPEL releases...
Done.
New spec/src.rpm:
Spec URL: https://www.scrye.com/~kevin/fedora/review/python-pycdio/python-pycdio.spec SRPM URL: https://www.scrye.com/~kevin/fedora/review/python-pycdio/python-pycdio-2.0.0...