Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hunspell-ee - Estonian hunspell dictionaries
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228471
wolfy@nobugconsulting.ro changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |wolfy@nobugconsulting.ro Flag| |fedora-review+
------- Additional Comments From wolfy@nobugconsulting.ro 2007-02-13 05:59 EST ------- - package meets naming guidelines - package meets packaging guidelines - spec file legible, in am. english - source matches upstream , sha1sum 4289cdd695eba079aceed471954f0adfc8059ffa et_EE.aff 712f4651ae2a82bea216cad78b144d182ad1c06f et_EE.dic - the package builds in mock for devel/x86_64, generates a noarch (which is consistent with the fact that basically it includes only 2 text files) - the license LGPL stated in the tag is the same as upstream's web site (http://www.meso.ee/~jjpp/speller/,Litsents ) says; the actual license is not included in the final rpm because upstream does not supply an actual "release" but just the two dictionary files - there are only 2 files (word lists) so no .la, .pc, static files - no missing BR - no locales - not relocatable - owns all files/directories that it creates, does not take ownership of other files/dirs - no duplicate files - permissions ok - %clean ok - macro use consistent - rpmlint output is silent on src.rpm; binary gives the following warning: W: hunspell-ee no-documentation which is consistent with the fact that there is nothing in the rpm but the two dictionary files - code, not content - no need for .desktop file
APPROVED
Obs: please bug upstream to include the LGPL license in case they release the dictionary as a single file (tar/zip/whatever); it would also be a good idea if their dict files would be available at http://ftp.services.openoffice.org/pub/OpenOffice.org/contrib/dictionaries/