Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690360
--- Comment #6 from Justin Morgan jpmorgan@learn.senecac.on.ca 2011-04-10 22:46:19 EDT --- (In reply to comment #5)
[?] MUST: The License field in the package spec file must match the actual license.
-> How do you know the actual license?
Answer: The license I've used comes from the License block contained in the PHP files (Ex. reg-server/1.0/index.php). It's also the standard Mozilla tri-license. Latest release (0.2-1) reflects this.
[N] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this.
-> Is the tarball not directly obtainable from the upstream source? If so, give the URL to the upstream location.
Answer: Unfortunately there are two separate upstream sources for this version of weave, one for sync-server and another for reg-server. These "source" tar-balls also contain mercurial files that I've manually stripped to create my own sources.
[N] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory.
-> Package does not own /usr/share/weave but should (directory is exclusive to this package)
* Corrected in 0.2-1
[N] MUST: A Fedora package must not list a file more than once in the spec file's %files listings.
-> file listed twice: /etc/httpd/conf.d/weave.conf
* Corrected in 0.2-1
[N] MUST: Each package must consistently use macros.
-> Do not use both $RPM_BUILD_ROOT and %{buildroot} in the spec file.
* Corrected in 0.2-1
[N] MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time.
-> Package owns /etc/httpd/conf.d but should not (directory is owned by httpd)
* Corrected in 0.2-1
[N] SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available.
Answer: All Weave documentation is currently in English. Both in README's and from Mozilla web documentation.
Also: -> README files under /usr/share/weave/ should be %doc
Answer: Those README's are no longer included with the latest source, as they include manual installation instructions no longer applicable for the packaged version.
-> There's a dependency on mysql-server, but the server might be installed on another host. No dependencies are usually set on database servers for this reason.
* Corrected in 0.2-1
-> Question: Should Aliases in weave.conf be commented out by default, until the user enables the server?
Answer: I'm a bit confused how to accomplish this. The only enabling the user does is apply the MySQL script (no BASH/etc). If you have any thoughts on how I may go about this I would certainly like to give it a shot.
----------------------------------------
Release 0.2-2
SPEC: http://matrix.senecac.on.ca/~jpmorgan/SPECS/weave.spec SOURCE: http://matrix.senecac.on.ca/~jpmorgan/SOURCES/weave-0.2.tar.gz SRPM: http://matrix.senecac.on.ca/~jpmorgan/SRPMS/weave-0.2-1.fc14.src.rpm RPM: http://matrix.senecac.on.ca/~jpmorgan/RPMS/weave-0.2-1.fc14.noarch.rpm
Apologies for the issue you had finding the source last time. I'm ensuring the project wiki is updated with "all" the latest links if you have any further issues.