https://bugzilla.redhat.com/show_bug.cgi?id=2036396
--- Comment #3 from Jerry James loganjerry@gmail.com --- Thank you for the suggestions, Christopher!
(In reply to Christopher Crouse from comment #1)
[1] I would improve the readability in the %files section, by adding in a few new lines (personal preference), for example: ...
[snip]
[2] I would move the `%ifarch %{ocaml_native_compiler}` condition in the %files devel section of the spec to the bottom. Keeping it consistent with [1], and add a few additional new lines as well, for example:
Okay, I can see how that would help with readability. The current style is a carryover from other OCaml spec files, and has been partially baked into the opam2rpm tool I occasionally work on. I will consider changing the style to improve readability as you suggest. Arthur, I guess that means that I am reconsidering the answer I just gave you in the ocaml-odoc-parser review. :-)
[3] I would recommend using rpmautospec for the package once it is imported. It will make maintaining the *Release* field and writing %changelog messages unnecessary in the future. Documented here, if you're interested: https://docs.pagure.org/fedora-infra.rpmautospec/index.html
Richard Jones has a script that rebuilds all OCaml packages whenever there is an update to the base compiler. That script does not yet handle rpmautospec correctly, so I will forgo using it for now. Once his script is updated to handle that case, I'll be happy to switch over.