https://bugzilla.redhat.com/show_bug.cgi?id=1391951
--- Comment #4 from Remi Collet fedora@famillecollet.com --- (In reply to François Kooman from comment #2)
Notes in addition to the ones "inline":
- gh_date in the spec file seems wrong, release 1.12.4 was released much
more
This is only a comment ;) (only used when git snapshot are used, often for QA build)
recent than the indicated gh_date.
- Group: Development/Libraries, not a library, maybe Development/Tools is
more appropriate
Indeed
- There is still some remirepo stuff in the spec file regarding running
tests,
Should not hurt
is this intended? Probably not needed for Fedora?
BTW, auto cleaned, with the EL-5 stuff, when spec is copied into fedora repo (cleanup commit), ex, see http://pkgs.fedoraproject.org/cgit/rpms/php-alcaeus-mongo-php-adapter.git/co...
I just keep them to avoid having to maintain 2 versions of the spec file between review submission and approval.
- rpmlint complains about script intepreter: php-cs-fixer.noarch: E: wrong-script-interpreter /usr/bin/php-cs-fixer
/usr/bin/env php I guess this is a false positive?
Yes, this is deliberate. Nothing in Guidelines forbid the use of /usr/bin/env in shebang, and BTW, this allow to work with Software Collections (ok, mostly useful in EPEL)
And php-cli is properly required.
- Maybe the self-updater should be disabled? Although it does detect it only works for PHAR and then stops with error, so I guess it is fine like this
:)
Indeed.
- rpmlint: php-cs-fixer.src: W: strange-permission makesrc.sh 775, I guess
it expects 755 instead...
No, 755 raise the same rpmlint warning. False positive IMHO. This "source" need to be executable (and not used during the build)