Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=504524
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Flag| |fedora-review+
--- Comment #1 from Parag AN(पराग) panemade@gmail.com 2009-06-08 00:24:55 EDT --- Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1397935 + rpmlint is silent for SRPM and for RPM. + source files match upstream url a313e85c6e22eda8d8df1fdb835e5437ddab6225 SQL-Shell-1.14.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=3, Tests=31, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.35 cusr 0.04 csys = 0.42 CPU) + Package perl-SQL-Shell-1.14-1.fc12.noarch => Provides: perl(SQL::Shell) = 1.14 perl(SQL::Shell::Manual) = 1.6 perl(Tie::Rowset::InMemory) Requires: perl(Carp) perl(DBI) perl(File::Path) perl(IO::File) perl(URI::Escape) perl(constant) perl(strict) perl(vars) + Not a GUI application
Should 1) Add following for subpackage sqlsh %defattr(-,root,root,-)
APPROVED.