https://bugzilla.redhat.com/show_bug.cgi?id=1332720
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #2 from Rex Dieter rdieter@math.unl.edu --- builds/installs locally ok (with minor %%files adjustments, appears to be several small typos)
naming: ok
sources: ok 6a3ce0c4d1c08f0de1245c83795e207d kdepim-addons-16.04.0.tar.xz
URL: Not valid 1. Should fix URL to (something like): URL: https://quickgit.kde.org/?p=%%7Bframework%7D.git
macros: ok
scriptlets: ok
2. SHOULD fix Conflicts/Obsoletes to not use %{_isa} (but reference real packages):
Obsoletes: kdepim-libs%{?_isa} < 16.04.0 Conflicts: kdepim-libs%{?_isa} < 16.04.0
Otherwise, looks good, follows conventions of other kf5/pim related packages, APPROVED