https://bugzilla.redhat.com/show_bug.cgi?id=1208835
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com See Also| |https://bugzilla.redhat.com | |/show_bug.cgi?id=532231 Assignee|nobody@fedoraproject.org |panemade@gmail.com Summary|Review Request: |Re-Review Request: |gdouros-akkadian-fonts - A |gdouros-akkadian-fonts - A |font for Sumero-Akkadian |font for Sumero-Akkadian |cuneiform |cuneiform Flags| |fedora-review?
--- Comment #2 from Parag AN(पराग) panemade@gmail.com --- Review:
+ mock build is successful for F23 (x86_64)
+ rpmlint on generated rpms gave output 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
+ Source verified with upstream as (sha256sum) srpm Source0: fd00741c13e0e822a97a6451b1fe406fcdab09f9e4bd77fe6a3eede3d8f5ea61 upstream Source0 : fd00741c13e0e822a97a6451b1fe406fcdab09f9e4bd77fe6a3eede3d8f5ea61 srpm Source1 : 15115616d2e04f36ac53b7d45e87dbfc77a1d810f6b4659dc70127935bae7e59 upstream Source1 : 15115616d2e04f36ac53b7d45e87dbfc77a1d810f6b4659dc70127935bae7e59
+ License is "Public Domain" as per given on upstream website "Fonts and documents in this site are not pieces of property or merchandise items; they carry no trademark, copyright, license or other market tags; they are free for any use". So no license text is included in font file or any text file
+ follows fonts packaging guidelines.
+ fontconfig file is present at priority 65.
+ Appdata metainfo file is present.
Suggestions: 1) I propose to follow https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packag... with following changes
%global checkout 20150430
Release: 0.2.%{checkout}%{?dist}
also add changelog that uses 7.13-0.2.20150430
The reason why I am not considering 7.15 as version is that it can be mistake by upstream to write the archive as 7.15.