Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: wammu - Mobile Phone Manager Frontend - Gammu GUI
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239527
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From panemade@gmail.com 2007-06-06 02:34 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url dfacac02d07ad7c1b324f0cc907bb555 wammu-0.19.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no -devel subpackage + no .la files. + translations are available + Does owns the directories it creates. + no scriptlets present. + desktop file installed correctly. + no duplicates in %files. + file permissions are appropriate. + Requires: /usr/bin/python gammu python(abi) = 2.5 python-gammu + GUI app.
APPROVED.