https://bugzilla.redhat.com/show_bug.cgi?id=1398922
--- Comment #12 from Michael Schwendt bugs.michael@gmx.net --- The fedora-review tool is equally helpful to the package maintainer as to the reviewer.
About GPLv2 or GPLv2+, a simple grep turns up these false positives:
$ grep "or later" * -R libtraceevent/trace-seq.c: * into a special buffer (@s) for later retrieval by a sequencer libtraceevent/event-parse.c: /* Save for later use. */
- These BR are not needed: gcc
Wouldn't be a big issue. The default buildroot doesn't contain gcc-c++ anymore, however. So, if gcc were not found, you would notice that with a failing build.
- Unversioned so-files not in -devel subpackage.
They are dlopen()ed plugins. I'd rather adjust the INSTALL_LIB_PATH definition before compiling uftrace and install them into a private path below $libdir instead of directly into $libdir.