Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=564567
--- Comment #22 from René Ribaud rene.ribaud@free.fr 2010-04-04 12:40:11 EDT --- (In reply to comment #21)
Hello Mamoru,
Thanks again for this new review. I have made a new package.
Please look at my comments below :
- SourceURL
...
- So the URL recommended by Fedora seems to be working.
You are right. I apologize because I didn't think that a link could exist.
- autogen.sh
- If this is needed, it is more readable to add autogen.sh as SourceX and copy it to build directory, rather than to create a patch which generates autogen.sh.
- It is recommended to call autogen.sh in %prep, rather than in %build.
Done.
- automated autotool call
...
I have modified autogen.sh with all your advises and inserted your patch.
You will be able to find the new package here :
Spec URL: http://uggla.free.fr/rpmbuild/SPECS/gwaei.spec SRPM URL: http://uggla.free.fr/rpmbuild/SRPMS/12/gwaei-1.3.0-3.fc12.src.rpm
RPMLINT output : ---------------- [ctb@uggla x86_64]$ rpmlint gwaei-1.3.0-3.fc12.x86_64.rpm gwaei.x86_64: W: spelling-error %description -l en_US kanji -> Kantian, Kanpur, Kansas gwaei.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/gwaei.schemas gwaei.x86_64: W: dangerous-command-in-%pre rm gwaei.x86_64: W: dangerous-command-in-%post rm 1 packages and 0 specfiles checked; 0 errors, 4 warnings.
[ctb@uggla SRPMS]$ rpmlint gwaei-1.3.0-3.fc12.src.rpm gwaei.src: W: spelling-error %description -l en_US kanji -> Kantian, Kanpur, Kansas 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
KOJI output : -------------
I have built the package with koji on all architectures for F12, F13 and rawhide. You can look at the F12 result here : http://koji.fedoraproject.org/koji/taskinfo?taskID=2094487
F13 here : http://koji.fedoraproject.org/koji/taskinfo?taskID=2094502
and F14 here : http://koji.fedoraproject.org/koji/taskinfo?taskID=2094512
Waiting for your feedbacks.
Best regards. René