https://bugzilla.redhat.com/show_bug.cgi?id=979124
--- Comment #6 from Michael Schwendt <mschwendt(a)gmail.com> ---
No further review, just these comments:
I also asked about the lgpl exception on the maillinglist (CC'd
you).
Thanks! It could be worthwhile to add a comment to the spec file about that,
also pointing out that the license terms are the same than in "qt" and
"qt-creator".
I hope I caught all unowned directories (is there some kind of tool
to help checking for this?).
Not that I know of. An experimental script I've published several years ago
(dircheck-remote.py) has not been developed further after it had been used to
report lots of unowned dirs. An improved tool would not only need to find
unowned directories, but also attempt at suggesting which packages in the
distribution ought to own the directories. Else packagers misinterpret the
results and add directories to the wrong packages just to please the tool. In
the past, so-called "multiple ownership of directories" has not been permitted.
Nowadays, the directory ownership guidelines are more lax. That means, in some
cases you don't need to strictly require a separate package just to get
complete directory ownership. You can include some directories in your own
package to avoid a dependency (provided that you copy the correct permissions):
https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owne...
Common sense, a good understanding of your own package inter-dependencies and
package contents, knowledge of the guidelines and "filesystem" packages, and
basic package queries with "rpmls -p" (or "rpm -qlvp") should be
enough to spot
missing dir entries. For example, with a first brief look such as
$ rpmls -p qbs-1.0.1-1.fc19.x86_64.rpm|grep ^d
drwxr-xr-x /usr/lib64/qbs
drwxr-xr-x /usr/lib64/qbs/plugins
drwxr-xr-x /usr/share/qbs/imports
drwxr-xr-x /usr/share/qbs/imports/qbs
drwxr-xr-x /usr/share/qbs/imports/qbs/base
drwxr-xr-x /usr/share/qbs/imports/qbs/base/qmlapplicationviewer
drwxr-xr-x /usr/share/qbs/imports/qbs/fileinfo
drwxr-xr-x /usr/share/qbs/imports/qbs/probes
drwxr-xr-x /usr/share/qbs/modules/qbs
one can see that there is no 'd' entry for /usr/share/qbs. With a look at the
%files section (any files with long paths there?) or a second query (without
grep ^d) you can check all files in a package and determine whether any parent
dirs are missing and belong into your package(s). Very often that's simple
enough.
Of course, for huge packages which contain deep file trees, often you would
include only the top dir path in the %files section and be done. If, on the
contrary, you create many subpackages with complex inter-dependencies,
directory ownership gets more complicated, too. Eventually you'll find that
splitting of a shared -filesystem subpackage may be helpful.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=g5fR95FcLZ&a=cc_unsubscribe