https://bugzilla.redhat.com/show_bug.cgi?id=1202295
John Dulaney jdulaney@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jdulaney@fedoraproject.org
--- Comment #6 from John Dulaney jdulaney@fedoraproject.org --- A few rpmlint issues:
xonsh.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/xonsh/xoreutils/_which.py 644 /usr/bin/env xonsh.noarch: E: script-without-shebang /usr/lib/python3.4/site-packages/xontrib/pyselect.xsh xonsh.noarch: W: no-manual-page-for-binary xonsh
Also, the separate spec file is different from that in the srpm:
[jdulaney@bodrog review]$ diff -u xonsh.spec ../rpmbuild/SPECS/xonsh.spec --- xonsh.spec 2016-06-04 21:25:06.000000000 +0000 +++ ../rpmbuild/SPECS/xonsh.spec 2016-06-04 21:08:36.000000000 +0000 @@ -9,6 +9,9 @@ License: BSD URL: https://github.com/scopatz/xonsh Source0: https://pypi.python.org/packages/source/x/%%7Bpypi_name%7D/%%7Bpypi_name%7D-... +# It may look nice but the logo is just redudant spam +# in build process +#Patch0: 001-remove-logo-from-setup.patch BuildArch: noarch
BuildRequires: python3-devel
You may want to change the url to the new pypi.io.
Also, not sure if we should consider the old review abandoned or not; if so, I think the procedure is to close this one and start a fresh review.