https://bugzilla.redhat.com/show_bug.cgi?id=2212222
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Flags| |fedora-review? Status|NEW |ASSIGNED CC| |decathorpe@gmail.com
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- Some minor issues:
1. The upstream license seems to be GPL-3.0-or-later, not GPL-3.0-only (see help text output at the bottom of "src/greeter.rs") - yes, it would be good if upstream had this in the Cargo.toml metadata (i.e. [package] license = "GPL-3.0-or-later").
2. Why is the version of the tarball 0.8.0 but the one in the Cargo metadata is 0.7.3? Did upstream tag a new version without bumping the version in metadata? There is no rationale for the patch other than "fix crate version".
3. Remove "ExclusiveArch: %{rust_arches}". It is a noop that is no longer needed, and it is no longer mandated by the Packaging Guidelines.
Other than that, package looks good.