Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=664298
--- Comment #4 from Thibault North thibault.north@gmail.com 2010-12-20 09:27:18 EST --- Thanks a lot for your review. I applied your suggestions and re-uploaded the package and the spec at the same address.
gzip %{name}.1 is not necessary - mans gzipped automatically.
Right, thanks.
%{_bindir}/* I'm prefer exact mention files to avoid acidentally includes in this and next builds: %{_bindir}/%{name} %{_bindir}/jumpapplet
Done.
%{_datadir}/%{name}* In case it globed into %{_datadir}/%{name} its ok, but for whate there asterisk?? If package name changed directory also changed. I'm highly recommend replace it by include just one directory: %{_datadir}/%{name}
Done.
%{_mandir}/man1/%{name}* %{_mandir}/man1/%{name}.1* also more preferred.
Done.
[-] MUST: The License field in the package spec file must match the actual license. README.rst stated it should be GPLv3+, not exactly GPLv3.
Right, sorry.
File listed twice: %{_datadir}/zsh/site-functions/ %{_datadir}/zsh/site-functions/_j
This I forgot to remove :) Done.
[+/-] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency.
Done.
Thank you.