Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=681393
--- Comment #3 from Steve Traylen <steve.traylen(a)cern.ch> 2011-03-03 14:09:53 EST
---
- Package meets naming and packaging guidelines
It does.
- Spec file matches base package name.
Yes.
- Spec has consistant macro usage.
Yes.
- Meets Packaging Guidelines.
Yes
- License
GPL+ or Artistic
- License field in spec matches
It does.
- License file included in package
It does
- Spec in American English
Yes.
- Spec is legible.
Yes.
- Sources match upstream md5sum:
$ md5sum Nagios-Plugin-WWW-Mechanize-0.13.tar.gz
../SOURCES/Nagios-Plugin-WWW-Mechanize-0.13.tar.gz
8cfc2c93d84a88756666c3d7a6baf69e Nagios-Plugin-WWW-Mechanize-0.13.tar.gz
8cfc2c93d84a88756666c3d7a6baf69e
../SOURCES/Nagios-Plugin-WWW-Mechanize-0.13.tar.gz
- BuildRequires correct
Yes
- Package has %defattr and permissions on files is good.
- Package has a correct %clean section.
- Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
- Package is code or permissible content.
- Doc subpackage needed/used
Not needed.
- Packages %doc files don't affect runtime.
The don't
- Package doesn't own any directories other packages own.
- Package owns all the directories it creates.
- No rpmlint output.
rpmint is clean as above.
- final provides and requires are sane:
COMMENT , a few double requires that could be cleaned up.
SHOULD Items:
- Should build in mock.
Yes
- Should build on all supported archs
Yes
- Should function as described.
The checks work at lease.
- Should have dist tag
Yes.
- Should package latest version
Yes it's the latest
Issues:
1) I'm not entirely sure why to be honest but in the past I've been asked to
change
make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
to
make pure_install DESTDIR=$RPM_BUILD_ROOT
2) You have in your .spec file an explicit
Requires: perl(Nagios::Plugin)
Requires: perl(WWW::Mechanize)
which results in double entries in the requires from
rpm -qp --requires perl-Nagios-Plugin-WWW-Mechanize-0.13-2.fc14.noarch.rpm
As a gneral rule if yours requires are being auto determined you should not
include
them explicitly.
3) Something I try and do is when you have a BuildRequires that is only needed
on EL6
then I place it inside an OS conditional
http://fedoraproject.org/wiki/DistTag#Conditionals
This makes it obvious that when RHEL6 is buried you can get rid of these lines.
Of course
sometimes it is requirement since the dependency names changes between
releases.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.