[Bug 1787216] New: Review Request: python-aiomysql - MySQL driver
for asyncio
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1787216
Bug ID: 1787216
Summary: Review Request: python-aiomysql - MySQL driver for
asyncio
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: mail(a)fabian-affolter.ch
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-aiomysql.spec
SRPM URL:
https://fab.fedorapeople.org/packages/SRPMS/python-aiomysql-0.0.20-1.fc31...
Project URL: https://github.com/aio-libs/aiomysql
Description:
aiomysql is a "driver" for accessing a MySQL database from the asyncio
(PEP-3156/tulip) framework. It depends on and reuses most parts of PyMySQL.
aiomysql tries to be like awesome aiopg library and preserve same api, look
and feel.
Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=40026983
rpmlint output:
$ rpmlint python-aiomysql-0.0.20-1.fc31.src.rpm
python-aiomysql.src: W: spelling-error Summary(en_US) asyncio -> syncopation
python-aiomysql.src: W: spelling-error %description -l en_US asyncio ->
syncopation
python-aiomysql.src: W: spelling-error %description -l en_US aiopg -> airdrop
python-aiomysql.src: W: spelling-error %description -l en_US api -> API, pi,
ape
python-aiomysql.src:43: W: macro-in-comment %check
python-aiomysql.src:44: W: macro-in-comment %{buildroot}
python-aiomysql.src:44: W: macro-in-comment %{python3_sitelib}
python-aiomysql.src:44: W: macro-in-comment %{python3_version}
1 packages and 0 specfiles checked; 0 errors, 8 warnings.
$ rpmlint python3-pymeeus-0.3.6-1.fc31.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[fab@whitebox1113 noarch]$ rpmlint python3-aiomysql-0.0.20-1.fc31.noarch.rpm
python3-aiomysql.noarch: W: spelling-error Summary(en_US) asyncio ->
syncopation
python3-aiomysql.noarch: W: spelling-error %description -l en_US asyncio ->
syncopation
python3-aiomysql.noarch: W: spelling-error %description -l en_US aiopg ->
airdrop
python3-aiomysql.noarch: W: spelling-error %description -l en_US api -> API,
pi, ape
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
Fedora Account System Username: fab
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4 years, 4 months
[Bug 1339227] Review Request: fileobj - Hex Editor written in Python
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1339227
--- Comment #10 from kusumi.tomohiro(a)gmail.com ---
Thanks for your comments.
Updated spec file and SRPM are available at below.
https://leaf.dragonflybsd.org/~tkusumi/rpms/fedora31_v2/
> - Not needed, if thebuild is not set as noarch then it is arched by default:
>
> # fileobj contains C extension
> BuildArch: x86_64
Removed BuildArch.
>
>
> - Glob the man page extension as the compression may change in the future:
>
> %{_mandir}/man1/%{srcname}.1.*
Glob'd the man page.
>
> - Source is 404:
>
> Source0: %{pypi_source}
>
> You don't seem to have published it on Pypi: https://pypi.org/search/?q=fileobj
>
> Use Github then:
>
> Source0: %url/archive/v%{version}/%{name}-%{version}.tar.gz
Changed it to a GitHub URL.
>
> - Since it is a binary package, I think you should just name it fileobj and not provide a python3 subpackage.
>
> Name: fileobj
>
> […]
>
> %files
> %license COPYING
> %doc CHANGES CONTRIBUTORS PKG-INFO README.md RELEASES
> %{python3_sitearch}/%{srcname}-*.egg-info
> %{python3_sitearch}/%{srcname}/
> %{_bindir}/%{srcname}
> %{_mandir}/man1/%{srcname}.1.*
Changed it to "fileobj" package.
Also removed %python_provide macro part for python3- package based on what's
mentioned in below.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_provides
>
> - You need to BR gcc as well:
>
> BuildRequires: python3-devel
> BuildRequires: gcc
Added gcc.
>
> - PKG-INFO is not found, don't include it
>
> RPM build errors:
> File not found: /builddir/build/BUILDROOT/fileobj-0.7.94-1.fc32.x86_64/usr/share/doc/fileobj/PKG-INFO
Removed PKG-INFO.
Looks like a tarball from GitHub doesn't contain PKG-INFO, while sdist'd
tarball from upstream source does contain PKG-INFO, and my SRPM previously
contained sdist'd tarball.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4 years, 4 months
[Bug 1019770] Review Request: lua-term - lua module for manipulating
terminal
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1019770
Jiri Machala <george.machala+rhbugzilla(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|needinfo?(george.machala+rh |
|bugzilla(a)gmail.com) |
--- Comment #8 from Jiri Machala <george.machala+rhbugzilla(a)gmail.com> ---
I'm sorry for not responding, I lost interest in this long time ago due to
circumstances and also lost track of this (I stumbled now upon reminding
email).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4 years, 4 months