[Bug 1326504] Review Request: htslib - C library for high-throughput
sequencing data formats (required for `samtools`)
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1326504
Dave Love <dave.love(a)manchester.ac.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |needinfo?(bloch(a)verdurin.co
| |m)
--- Comment #15 from Dave Love <dave.love(a)manchester.ac.uk> ---
Adam: can you still review this?
From a quick look:
licensecheck says Expat rather than MIT -- I haven't checked
You could use %make_build in %build
Remove the obsolete rm -rf from %install
To support EPEL, use %ldconfig_scriptlets instead of %post...
The library needs sorting out. Its soname is libhts.so.2, but
it's installed as libhts.so.1.9 with a symlink to libhts.so.2. I
haven't checked what's going on. The %files entry for it should
be libhts.so.2*, so you know if it changes. If the version is
actually taken from the release version -- I dont know -- it
shouldn't be, and could be set to 0 for Fedora.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4 years, 7 months
[Bug 1209809] Review Request: rubyripper - cdparanoia based high
quality cd ripper
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1209809
Ben Rosser <rosser.bjr(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rosser.bjr(a)gmail.com
Flags| |needinfo?(Benjamin@BGRobert
| |s.id.au)
--- Comment #3 from Ben Rosser <rosser.bjr(a)gmail.com> ---
Hi,
I'm very sorry this has sat in the queue for so long-- unfortunately sometimes
things get overlooked. :(
Are you still interested in this package and becoming a packager? I'd be happy
to review it and sponsor you.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4 years, 7 months
[Bug 1750501] Review Request: fastbit - An Efficient Compressed
Bitmap Index Technology (UNRETIRE)
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1750501
Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
CC| |zbyszek(a)in.waw.pl
Assignee|nobody(a)fedoraproject.org |zbyszek(a)in.waw.pl
--- Comment #12 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
Replying to some earlier comments first:
> Unversioned so-files
> --------------------
> fastbit-java: /usr/lib64/fastbit/libfastbitjni.so
That's OK. The file is not in the normal library lookup path.
> - Package does not use a name that already exists.
This is a re-review, so the package obviously exists. fedora-review could be
smarter, but it's not.
When using fedora-review, please remove such comments in the future from it's
output when it is
clear that it is wrong.
> # Main package is BSD; the Bison-generated parsers are GPLv3+ with exceptions;
> # contribs/fbmerge is GPLv2+
> License: BSD and GPLv3+ with exceptions and GPLv2+
This one actually should be changed. A license describes the *binary* package
[1]. In this particular case,
the parser parts can only be included in the package because of the license
exception. As the GPLv3-exception
header says, "you may distribute that work under the terms of your choice".
This is exactly what is happening
here: the authors are distributing fastbit under the BSD license. Please remove
any mention of GPLv3+ from the
License lines.
Also, if fbmerge is GPLv2+, then this doesn't matter for the -devel and -java
subpackages. Their license
is just "BSD".
[1]
https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#Does_the_Li...
Otherwise, looks OK.
+ package name is OK
+ latest version
+ builds and installs OK
+ fedora-review is happy
+ scriptlets look OK (there are none ;))
+ Provides/Requires/BR look OK
Package is RE-APPROVED. Please fix the license bits when re-importing.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4 years, 7 months