[Bug 1680374] New: Review Request: perl-IO-Prompter - Prompt for
input, read it, clean it, return it
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1680374
Bug ID: 1680374
Summary: Review Request: perl-IO-Prompter - Prompt for input,
read it, clean it, return it
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: besser82(a)fedoraproject.org
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Description:
IO::Prompter exports a single subroutine, prompt, that prints a prompt
(but only if the program's selected input and output streams are connected
to a terminal), then reads some input, then chomps it, and finally returns
an object representing that text.
Issues:
fedora-review shows no obvious issues. rpmlint is silent.
FAS-User:
besser82
Urls:
Spec URL:
https://pagure.io/besser82/package-review/raw/master/f/perl-IO-Prompter.spec
SRPM URL:
https://pagure.io/besser82/package-review/raw/master/f/perl-IO-Prompter-0...
Thanks for review in advance!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5 years, 3 months
[Bug 1483262] Review Request: phpdoc - Documentation generator for
PHP
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1483262
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ON_QA |CLOSED
Resolution|--- |ERRATA
Last Closed| |2019-03-06 06:58:10
--- Comment #21 from Fedora Update System <updates(a)fedoraproject.org> ---
phpdoc-2.9.0-7.fc29 has been pushed to the Fedora 29 stable repository. If
problems still persist, please make note of it in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5 years, 3 months
[Bug 1643742] Review Request: golang-etcd-bbolt - An embedded
key/value database for Go
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1643742
Elliott Sales de Andrade <quantum.analyst(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |quantum.analyst(a)gmail.com
Assignee|nobody(a)fedoraproject.org |quantum.analyst(a)gmail.com
Flags| |fedora-review?
--- Comment #1 from Elliott Sales de Andrade <quantum.analyst(a)gmail.com> ---
Update to 1.3.2 and you can drop the commit hash and 0 release.
How much memory does %gochecks use? Maybe that can be reported upstream, or
maybe it's fixed already. Also, I think builders have a ridiculous amount of
RAM... I tried uncommenting it and it uses max ~2.6 G; this should be fine,
except maybe 32-bit. Might want to try a scratch build to be sure.
Can remove the %license tag re-definition.
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Expat License", "Unknown or generated". 43 files have unknown
license. Detailed output of licensecheck in
1643742-golang-etcd-bbolt/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gocode/src,
/usr/share/gocode, /usr/share/gocode/src/github.com
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
etcd-bbolt-devel , compat-golang-github-coreos-bbolt-devel
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking:
golang-etcd-bbolt-devel-1.3.1-0.4.etcd.8.20181005git7ee3ded.fc30.x86_64.rpm
compat-golang-github-coreos-bbolt-devel-1.3.1-0.4.etcd.8.20181005git7ee3ded.fc30.noarch.rpm
golang-etcd-bbolt-1.3.1-0.4.etcd.8.20181005git7ee3ded.fc30.src.rpm
golang-etcd-bbolt-devel.x86_64: W: hidden-file-or-dir
/usr/share/gocode/src/go.etcd.io/bbolt/.goipath
compat-golang-github-coreos-bbolt-devel.noarch: W: no-documentation
compat-golang-github-coreos-bbolt-devel.noarch: W: dangling-symlink
/usr/share/gocode/src/github.com/coreos/bbolt
/usr/share/gocode/src/go.etcd.io/bbolt
golang-etcd-bbolt.src: W: no-%build-section
3 packages and 0 specfiles checked; 0 errors, 4 warnings.
Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:
Requires
--------
compat-golang-github-coreos-bbolt-devel (rpmlib, GLIBC filtered):
golang-ipath(go.etcd.io/bbolt)
golang-etcd-bbolt-devel (rpmlib, GLIBC filtered):
Provides
--------
compat-golang-github-coreos-bbolt-devel:
compat-golang-github-coreos-bbolt-devel
golang(github.com/coreos/bbolt)
golang(github.com/coreos/bbolt)(commit=7ee3ded59d4835e10f3e7d0f7603c42aa5...
golang(github.com/coreos/bbolt/cmd)
golang(github.com/coreos/bbolt/cmd)(commit=7ee3ded59d4835e10f3e7d0f7603c4...
golang(github.com/coreos/bbolt/cmd/bbolt)
golang(github.com/coreos/bbolt/cmd/bbolt)(commit=7ee3ded59d4835e10f3e7d0f...
golang-etcd-bbolt-devel:
golang(go.etcd.io/bbolt)
golang(go.etcd.io/bbolt)(commit=7ee3ded59d4835e10f3e7d0f7603c42aa5e83820)
golang-etcd-bbolt-devel
golang-etcd-bbolt-devel(x86-64)
golang-ipath(go.etcd.io/bbolt)
golang-ipath(go.etcd.io/bbolt)(commit=7ee3ded59d4835e10f3e7d0f7603c42aa5e83820)
Source checksums
----------------
https://github.com/etcd-io/bbolt/archive/7ee3ded59d4835e10f3e7d0f7603c42a...
:
CHECKSUM(SHA256) this package :
7e0fb20ed8c3fd5fefb862e4a806907ade6a16655b8c168aa80939ea2c69f188
CHECKSUM(SHA256) upstream package :
7e0fb20ed8c3fd5fefb862e4a806907ade6a16655b8c168aa80939ea2c69f188
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1643742
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5 years, 3 months