https://bugzilla.redhat.com/show_bug.cgi?id=1647147
Marcin Ślusarz <marcin.slusarz(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|POST |CLOSED
Resolution|--- |RAWHIDE
Last Closed| |2018-12-17 13:41:48
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1647145
Marcin Ślusarz <marcin.slusarz(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|POST |CLOSED
Resolution|--- |RAWHIDE
Last Closed| |2018-12-17 13:41:36
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1658851
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #4 from Petr Pisar <ppisar(a)redhat.com> ---
The spec file changes:
--- perl-Schedule-Cron.spec.old 2018-12-14 14:09:48.827000000 +0100
+++ perl-Schedule-Cron.spec 2018-12-17 10:32:01.556000000 +0100
@@ -3,7 +3,6 @@
Version: 1.01
Release: 1%{?dist}
License: GPL+ or Artistic
-Group: Development/Libraries
URL: https://metacpan.org/release/Schedule-Cron
BuildArch: noarch
@@ -12,19 +11,34 @@
# shown in Makefile.PL
Source1: http://dev.perl.org/licenses/#/%{name}-Licensing.html
-Patch0:
https://github.com/rhuss/schedule-cron/pull/8.patch#/perl-schedule-cron-fix…
+# https://github.com/rhuss/schedule-cron/pull/8
+Patch0: perl-schedule-cron-fix-unescaped-left-brace.patch
# Patch obtained from Debian libschedule-cron-perl source package
Patch1: perl-schedule-cron-fix-spelling.patch
-BuildRequires: perl-devel
BuildRequires: perl-interpreter
BuildRequires: perl-generators
BuildRequires: perl(ExtUtils::MakeMaker)
+BuildRequires: perl(File::Basename)
+BuildRequires: perl(strict)
+BuildRequires: perl(warnings)
+BuildRequires: perl(Data::Dumper)
+BuildRequires: perl(subs)
+BuildRequires: perl(vars)
BuildRequires: findutils
+BuildRequires: coreutils
# Needed during build for the perl test
-BuildRequires: perl(Time::ParseDate)
-BuildRequires: perl(Test::More)
+BuildRequires: perl(Time::ParseDate) >= 2011.0505
+BuildRequires: perl(Test::More)
+BuildRequires: perl(Test::Pod)
+BuildRequires: perl(Test::Pod::Coverage)
+BuildRequires: perl(Test::Kwalitee)
+
+Requires: perl(Config)
+Requires: perl(Time::ParseDate) >= 2011.0505
+Requires: perl(POSIX)
+Requires: perl(Term::ReadLine)
%description
This module provides a simple but complete cron like scheduler. I.e
@@ -57,14 +71,13 @@
cp -a %{SOURCE1} Licensing.html
%build
-%{__perl} Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1
+%{__perl} Makefile.PL INSTALLDIRS=vendor NO_PERLLOCAL=1
%make_build
%install
%make_build pure_install DESTDIR=%{buildroot}
find %{buildroot} -type f -name .packlist -delete
-find %{buildroot} -type d -empty -delete
%{_fixperms} %{buildroot}/*
The changes are good.
TODO: Except I do not recommend running the optional tests with Test::Kwalitee
or Test::Pod. They are very fragile and tends to break when somebody updates
the modules (Test::Kwalitee is a list of subjective rules how a good Perl code
looks like).
TODO: You should also build-require `perl(POSIX)' if you decided to
hard-require it. It's good to assure the tests have a similar environment as
the package has after installing on a user's system. Otherwise it can happen
that the tests test a different code path than the user will perform (see all
the $HAS_POSIX conditions in the code).
$ rpmlint perl-Schedule-Cron.spec
../SRPMS/perl-Schedule-Cron-1.01-1.fc30.src.rpm
../RPMS/noarch/perl-Schedule-Cron-1.01-1.fc30.noarch.rpm
perl-Schedule-Cron.src: W: spelling-error %description -l en_US crontab ->
contactable
perl-Schedule-Cron.noarch: W: spelling-error %description -l en_US crontab ->
contactable
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
rpmlint is Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Schedule-Cron-1.01-1.fc30.noarch.rpm
| sort -f | uniq -c
1 perl(Config)
1 perl(Data::Dumper)
1 perl(POSIX)
1 perl(strict)
1 perl(subs)
1 perl(Term::ReadLine)
1 perl(Time::ParseDate)
1 perl(Time::ParseDate) >= 2011.0505
1 perl(vars)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
The binary requires are Ok.
TODO: You can filter out the non-versioned `perl(Time::ParseDate)' dependency
as it's redundant and pollutes the metadata.
$ resolvedeps rawhide ../RPMS/noarch/perl-Schedule-Cron-1.01-1.fc30.noarch.rpm
Binary dependencies are resolvable. Ok.
The package builds in F30
(https://koji.fedoraproject.org/koji/taskinfo?taskID=31507198). Ok.
Otherwise the package is good.
Please consider fixing the `TODO' items before building the package.
Resolution: The package is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1655423
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|MODIFIED |CLOSED
Resolution|--- |ERRATA
Last Closed| |2018-12-17 02:27:35
--- Comment #6 from Fedora Update System <updates(a)fedoraproject.org> ---
php-sebastian-environment4-4.0.1-1.fc28 has been pushed to the Fedora 28 stable
repository. If problems still persist, please make note of it in this bug
report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1655785
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|RAWHIDE |ERRATA
--- Comment #6 from Fedora Update System <updates(a)fedoraproject.org> ---
golang-github-ovh-0-0.2.20181207gitba5adb4.fc28 has been pushed to the Fedora
28 stable repository. If problems still persist, please make note of it in this
bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1655679
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|RAWHIDE |ERRATA
--- Comment #6 from Fedora Update System <updates(a)fedoraproject.org> ---
golang-github-namedotcom-0-0.1.20181207git08470be.fc28 has been pushed to the
Fedora 28 stable repository. If problems still persist, please make note of it
in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1655664
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|RAWHIDE |ERRATA
--- Comment #6 from Fedora Update System <updates(a)fedoraproject.org> ---
golang-github-timewasted-linode-0-0.1.20181207git37e8452.fc28 has been pushed
to the Fedora 28 stable repository. If problems still persist, please make note
of it in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1634449
Bug 1634449 depends on bug 1634014, which changed state.
Bug 1634014 Summary: Review Request: python-grpcio - A high performance, open-source universal RPC framework
https://bugzilla.redhat.com/show_bug.cgi?id=1634014
What |Removed |Added
----------------------------------------------------------------------------
Status|POST |CLOSED
Resolution|--- |NOTABUG
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component