[Bug 1659281] Review Request: python-dictdiffer - Dictdiffer is a
module that helps you to diff and patch dictionaries
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1659281
Javier Peña <jpena(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #2 from Javier Peña <jpena(a)redhat.com> ---
In general terms the spec looks ok to me, there are just a couple issues to
fix:
- There is no need to add an explicit Requires: for python2 or python3, the
build process will figure it out and add it to the package.
- fedora-review complains that the spec from the SRPM and the one in the bug
are different, could you fix that?
- The cleanup for .buildinfo after building docs is not cleaning .doctrees, and
rpmlint complains about that
- Finally, there is an inconsistency in the build requirements for the doc
subpackage when using python2:
%else
BuildRequires: python2-sphinx
BuildRequires: python3-recommonmark <-- should be python2
%endif
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5 years, 6 months