[Bug 1659286] Review Request: python-openshift - Python client for
the OpenShift API
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1659286
Alfredo Moralejo <amoralej(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |amoralej(a)redhat.com
--- Comment #2 from Alfredo Moralejo <amoralej(a)redhat.com> ---
Some comments:
- Do we need epoch = 1, it's a bit weird to bump it for a new package (I guess
it's for compatibility with builds for non-fedora).
- Line 74: "Provides: %{name}-doc" must be removed, subpackage name provides is
automatic.
- Hidden directory /usr/share/doc/python-openshift-doc/html/.doctrees should be
removed after doc building.
- There are errors related to shebang/permissions with file client.py:
python3-openshift.noarch: E: wrong-script-interpreter
/usr/lib/python3.7/site-packages/openshift/dynamic/client.py /usr/bin/env
python
python3-openshift.noarch: E: non-executable-script
/usr/lib/python3.7/site-packages/openshift/dynamic/client.py 644 /usr/bin/env
python
If those are intended to be used as scripts, fix shebang (/usr/bin/env python
should not be used, but versioned one) and make them executable. Otherwise,
shebang should be removed and permissions should be kept to 644.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5 years, 4 months