[Bug 1478052] New: Review Request:
nuvola-app-google-play-music - Google Calendar web app for Nuvola Player 3
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1478052
Bug ID: 1478052
Summary: Review Request: nuvola-app-google-play-music - Google
Calendar web app for Nuvola Player 3
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: mgansser(a)online.de
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL:
https://martinkg.fedorapeople.org/Review/SPECS/nuvola-app-google-play-mus...
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/nuvola-app-google-play-mus...
Description: Integration of Google Calendar web app into your linux desktop via
Nuvola Apps.
Fedora Account System Username: martinkg
%changelog
* Fri Jul 28 2017 Martin Gansser <martinkg(a)fedoraproject.org> - 5.19-1
- initial build
rpmlint -i -v nuvola-app-google-play-music.spec
/home/martin/rpmbuild/SRPMS/nuvola-app-google-play-music-5.19-1.fc26.src.rpm
/home/martin/rpmbuild/RPMS/noarch/nuvola-app-google-play-music-5.19-1.fc26.noarch.rpm
nuvola-app-google-play-music.spec: I: checking
nuvola-app-google-play-music.spec:29: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.
nuvola-app-google-play-music.spec: I: checking-url
https://github.com/tiliado/nuvola-app-google-play-music/archive/5.19.tar....
(timeout 10 seconds)
nuvola-app-google-play-music.src: I: checking
nuvola-app-google-play-music.src: W: spelling-error %description -l en_US linux
-> Linux
The value of this tag appears to be misspelled. Please double-check.
nuvola-app-google-play-music.src: I: checking-url
https://github.com/tiliado/nuvola-app-google-play-music (timeout 10 seconds)
nuvola-app-google-play-music.src:29: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.
nuvola-app-google-play-music.src: I: checking-url
https://github.com/tiliado/nuvola-app-google-play-music/archive/5.19.tar....
(timeout 10 seconds)
nuvola-app-google-play-music.noarch: I: checking
nuvola-app-google-play-music.noarch: W: spelling-error %description -l en_US
linux -> Linux
The value of this tag appears to be misspelled. Please double-check.
nuvola-app-google-play-music.noarch: I: checking-url
https://github.com/tiliado/nuvola-app-google-play-music (timeout 10 seconds)
nuvola-app-google-play-music.noarch: W: desktopfile-without-binary
/usr/share/applications/eu.tiliado.NuvolaAppGooglePlayMusic.desktop nuvola
the .desktop file is for a file not present in the package. You should check
the requires or see if this is not a error
2 packages and 1 specfiles checked; 0 errors, 5 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6 years, 9 months
[Bug 1478067] New: Review Request:
nuvola-app-mixcloud - Mixcloud for Nuvola Player 3
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1478067
Bug ID: 1478067
Summary: Review Request: nuvola-app-mixcloud - Mixcloud for
Nuvola Player 3
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: mgansser(a)online.de
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL:
https://martinkg.fedorapeople.org/Review/SPECS/nuvola-app-mixcloud.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/nuvola-app-mixcloud-3.2-1....
Description: Mixcloud for Nuvola Player 3 : Integration of Mixcloud into your
linux desktop via Nuvola Player
Fedora Account System Username: martinkg
%changelog
* Fri Jul 28 2017 Martin Gansser <martinkg(a)fedoraproject.org> - 3.2-1
- initial build
rpmlint -i -v nuvola-app-mixcloud.spec
/home/martin/rpmbuild/SRPMS/nuvola-app-mixcloud-3.2-1.fc26.src.rpm
/home/martin/rpmbuild/RPMS/noarch/nuvola-app-mixcloud-3.2-1.fc26.noarch.rpm
nuvola-app-mixcloud.spec: I: checking
nuvola-app-mixcloud.spec:30: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.
nuvola-app-mixcloud.spec: I: checking-url
https://github.com/tiliado/nuvola-app-mixcloud/archive/3.2.tar.gz#/nuvola...
(timeout 10 seconds)
nuvola-app-mixcloud.src: I: checking
nuvola-app-mixcloud.src: W: spelling-error %description -l en_US linux -> Linux
The value of this tag appears to be misspelled. Please double-check.
nuvola-app-mixcloud.src: I: checking-url
https://github.com/tiliado/nuvola-app-mixcloud (timeout 10 seconds)
nuvola-app-mixcloud.src:30: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.
nuvola-app-mixcloud.src: I: checking-url
https://github.com/tiliado/nuvola-app-mixcloud/archive/3.2.tar.gz#/nuvola...
(timeout 10 seconds)
nuvola-app-mixcloud.noarch: I: checking
nuvola-app-mixcloud.noarch: W: spelling-error %description -l en_US linux ->
Linux
The value of this tag appears to be misspelled. Please double-check.
nuvola-app-mixcloud.noarch: I: checking-url
https://github.com/tiliado/nuvola-app-mixcloud (timeout 10 seconds)
nuvola-app-mixcloud.noarch: W: desktopfile-without-binary
/usr/share/applications/eu.tiliado.NuvolaAppMixcloud.desktop nuvola
the .desktop file is for a file not present in the package. You should check
the requires or see if this is not a error
2 packages and 1 specfiles checked; 0 errors, 5 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6 years, 9 months
[Bug 1467054] New: Review Request:
nuvola-app-google-calendar - Google Calendar web app for Nuvola Player 3
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1467054
Bug ID: 1467054
Summary: Review Request: nuvola-app-google-calendar - Google
Calendar web app for Nuvola Player 3
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: mgansser(a)online.de
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL:
https://martinkg.fedorapeople.org/Review/SPECS/nuvola-app-google-calendar...
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/nuvola-app-google-calendar...
Description: Integration of Google Calendar web app into your linux desktop via
Nuvola Apps.Fedora Account System Username: martinkg
rpmlint -i -v nuvola-app-google-calendar.spec
/home/martin/rpmbuild/SRPMS/nuvola-app-google-calendar-1.2-1.fc25.src.rpm
/home/martin/rpmbuild/RPMS/noarch/nuvola-app-google-calendar-1.2-1.fc25.noarch.rpm
nuvola-app-google-calendar.spec: I: checking
nuvola-app-google-calendar.spec:29: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.
nuvola-app-google-calendar.spec: I: checking-url
https://github.com/tiliado/nuvola-app-google-calendar/archive/1.2.tar.gz#...
(timeout 10 seconds)
nuvola-app-google-calendar.src: I: checking
nuvola-app-google-calendar.src: W: spelling-error %description -l en_US linux
-> Linux
The value of this tag appears to be misspelled. Please double-check.
nuvola-app-google-calendar.src: I: checking-url
https://github.com/tiliado/nuvola-app-google-calendar (timeout 10 seconds)
nuvola-app-google-calendar.src:29: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.
nuvola-app-google-calendar.src: I: checking-url
https://github.com/tiliado/nuvola-app-google-calendar/archive/1.2.tar.gz#...
(timeout 10 seconds)
nuvola-app-google-calendar.noarch: I: checking
nuvola-app-google-calendar.noarch: W: spelling-error %description -l en_US
linux -> Linux
The value of this tag appears to be misspelled. Please double-check.
nuvola-app-google-calendar.noarch: I: checking-url
https://github.com/tiliado/nuvola-app-google-calendar (timeout 10 seconds)
nuvola-app-google-calendar.noarch: W: desktopfile-without-binary
/usr/share/applications/eu.tiliado.NuvolaAppGoogleCalendar.desktop nuvola
the .desktop file is for a file not present in the package. You should check
the requires or see if this is not a error
2 packages and 1 specfiles checked; 0 errors, 5 warnings.
%changelog
* Sun Jul 02 2017 Martin Gansser <martinkg(a)fedoraproject.org> - 1.2-1
- initial build
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6 years, 9 months
[Bug 1480956] Review Request: golang-github-alecthomas-template -
Go'
s text/template package with newline elisio
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1480956
Robert-André Mauchin (afk until next Thu) <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |zebob.m(a)gmail.com
Assignee|nobody(a)fedoraproject.org |zebob.m(a)gmail.com
Flags| |fedora-review?
--- Comment #1 from Robert-André Mauchin (afk until next Thu) <zebob.m(a)gmail.com> ---
Hello,
Changelog version is in a wrong format again, it should be 0-0.1.gita0175ee
License tag is wrong, the package is not MIT but BSD:
https://github.com/alecthomas/template/blob/master/LICENSE
Your summary is missing a letter at the end: elisio → elision
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (3 clause)", "Unknown or generated". 20 files have unknown
license. Detailed output of licensecheck in /home/bob/packaging/review
/golang-github-alecthomas-template/review-golang-github-alecthomas-
template/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gocode/src,
/usr/share/gocode, /usr/share/gocode/src/github.com
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/gocode/src/github.com/alecthomas(golang-github-alecthomas-
repr-devel, golang-github-alecthomas-colour-devel, golang-github-
alecthomas-units-devel, golang-github-alecthomas-template-devel,
golang-github-alecthomas-assert-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
github-alecthomas-template-devel , golang-github-alecthomas-template-
unit-test-devel
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: golang-github-alecthomas-template-devel-0-0.1.fc27.noarch.rpm
golang-github-alecthomas-template-unit-test-devel-0-0.1.fc27.x86_64.rpm
golang-github-alecthomas-template-0-0.1.fc27.src.rpm
golang-github-alecthomas-template-devel.noarch: W: spelling-error
Summary(en_US) elisio -> elision, Eliseo
golang-github-alecthomas-template-devel.noarch: W: spelling-error %description
-l en_US elisio -> elision, Eliseo
golang-github-alecthomas-template.src: W: spelling-error Summary(en_US) elisio
-> elision, Eliseo
golang-github-alecthomas-template.src: W: spelling-error %description -l en_US
elisio -> elision, Eliseo
3 packages and 0 specfiles checked; 0 errors, 4 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6 years, 9 months
[Bug 1467049] New: Review Request:
nuvola-app-deezer - Deezer for Nuvola Player 3
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1467049
Bug ID: 1467049
Summary: Review Request: nuvola-app-deezer - Deezer for Nuvola
Player 3
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: mgansser(a)online.de
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvola-app-deezer.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/nuvola-app-deezer-2.6-1.fc...
Description: Integration of Deezer into your linux desktop via Nuvola Player.
Fedora Account System Username: martinkg
rpmlint -i -v nuvola-app-deezer.spec
/home/martin/rpmbuild/SRPMS/nuvola-app-deezer-2.6-1.fc25.src.rpm
/home/martin/rpmbuild/RPMS/noarch/nuvola-app-deezer-2.6-1.fc25.noarch.rpm
nuvola-app-deezer.spec: I: checking
nuvola-app-deezer.spec:29: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.
nuvola-app-deezer.spec: I: checking-url
https://github.com/tiliado/nuvola-app-deezer/archive/2.6.tar.gz#/nuvola-a...
(timeout 10 seconds)
nuvola-app-deezer.src: I: checking
nuvola-app-deezer.src: W: spelling-error %description -l en_US linux -> Linux
The value of this tag appears to be misspelled. Please double-check.
nuvola-app-deezer.src: I: checking-url
https://github.com/tiliado/nuvola-app-deezer (timeout 10 seconds)
nuvola-app-deezer.src:29: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.
nuvola-app-deezer.src: I: checking-url
https://github.com/tiliado/nuvola-app-deezer/archive/2.6.tar.gz#/nuvola-a...
(timeout 10 seconds)
nuvola-app-deezer.noarch: I: checking
nuvola-app-deezer.noarch: W: spelling-error %description -l en_US linux ->
Linux
The value of this tag appears to be misspelled. Please double-check.
nuvola-app-deezer.noarch: I: checking-url
https://github.com/tiliado/nuvola-app-deezer (timeout 10 seconds)
nuvola-app-deezer.noarch: W: desktopfile-without-binary
/usr/share/applications/eu.tiliado.NuvolaAppDeezer.desktop nuvola
the .desktop file is for a file not present in the package. You should check
the requires or see if this is not a error
2 packages and 1 specfiles checked; 0 errors, 5 warnings.
%changelog
* Sun Jul 02 2017 Martin Gansser <martinkg(a)fedoraproject.org> - 2.6-1
- Update to 2.6-1
* Sat Jan 21 2017 Martin Gansser <martinkg(a)fedoraproject.org> - 2.5-1
- initial build
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6 years, 9 months