[Bug 1462983] Review Request:
python-phonenumbers - A Python port of Google's libphonenumber
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1462983
Yatin Karel <ykarel(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ykarel(a)redhat.com
--- Comment #2 from Yatin Karel <ykarel(a)redhat.com> ---
This is un-official review of the package.
+ mock build is successful for fedora 25, fedora 26, tried package installation
on
fedora 25, it was successful and functional.
+ Source Checksum same
+ License "ASL 2.0" is in Socure repo and is included in subpackages
- rpmlint contains Errors:-
Rpmlint
-------
Checking: python2-phonenumbers-8.5.1-1.fc25.noarch.rpm
python3-phonenumbers-8.5.1-1.fc25.noarch.rpm
python-phonenumbers-8.5.1-1.fc25.src.rpm
python2-phonenumbers.noarch: W: spelling-error Summary(en_US) libphonenumber ->
cumbersomeness
python2-phonenumbers.noarch: W: spelling-error %description -l en_US
libphonenumber -> cumbersomeness
python2-phonenumbers.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/phonenumbers/util.py /usr/bin/env python
python2-phonenumbers.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/phonenumbers/util.py 644 /usr/bin/env python
python3-phonenumbers.noarch: W: spelling-error Summary(en_US) libphonenumber ->
cumbersomeness
python3-phonenumbers.noarch: W: spelling-error %description -l en_US
libphonenumber -> cumbersomeness
python3-phonenumbers.noarch: E: wrong-script-interpreter
/usr/lib/python3.5/site-packages/phonenumbers/util.py /usr/bin/env python
python3-phonenumbers.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/phonenumbers/util.py 644 /usr/bin/env python
python-phonenumbers.src: W: spelling-error Summary(en_US) libphonenumber ->
cumbersomeness
python-phonenumbers.src: W: spelling-error %description -l en_US libphonenumber
-> cumbersomeness
3 packages and 0 specfiles checked; 4 errors, 6 warnings.
Rest looks Ok, few suggestions below:-
1) - %files contains *, should be good if * is replaced with module_name
2) - use python2-%{pypi_name} instead of python[23]-phonenumbers for
consistency
3) use {} arond variables like __python --> %{__python} for consistency
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6 years, 11 months
[Bug 1462983] Review Request:
python-phonenumbers - A Python port of Google's libphonenumber
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1462983
Filip Szymański <filip.szymanski(a)zoho.eu> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |filip.szymanski(a)zoho.eu
--- Comment #1 from Filip Szymański <filip.szymanski(a)zoho.eu> ---
1) Remove `v` from `%{name}-v%{version}.tar.gz` in Source0.
2) Remove shebang from util.py:
Example:
%prep
%autosetup
sed -i.orig '1{\@^#!/usr/bin/env python@d}' python/phonenumbers/util.py
touch -r python/phonenumbers/util.py.orig python/phonenumbers/util.py
rm -f python/phonenumbers/util.py.orig
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6 years, 11 months