[Bug 1330856] Review Request: numix-gtk-theme - Numix Gtk Theme
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1330856
Simone Caronni <negativo17(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #11 from Simone Caronni <negativo17(a)gmail.com> ---
All requests have been satisfied, package approved!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8 years
[Bug 1153724] New: Review Request: golang-github-mitchellh-mapstructure - Go library for decoding generic map values into native Go structures
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1153724
Bug ID: 1153724
Summary: Review Request: golang-github-mitchellh-mapstructure -
Go library for decoding generic map values into native
Go structures
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: jchaloup(a)redhat.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL:
https://jchaloup.fedorapeople.org/reviews/golang-github-mitchellh-mapstru...
SRPM URL:
https://jchaloup.fedorapeople.org/reviews/golang-github-mitchellh-mapstru...
Description: mapstructure is a Go library for decoding generic map values to
structures
and vice versa, while providing helpful error handling.
This library is most useful when decoding values from some data stream (JSON,
Gob, etc.) where you don't quite know the structure of the underlying data
until you read a part of it. You can therefore read a map[string]interface{}
and use this library to decode it into the proper underlying
native Go structure.
Fedora Account System Username: jchaloup
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7883740
$ rpmlint
/home/jchaloup/rpmbuild/SRPMS/golang-github-mitchellh-mapstructure-0-0.1.git740c764.fc20.src.rpm
/home/jchaloup/rpmbuild/RPMS/noarch/golang-github-mitchellh-mapstructure-devel-0-0.1.git740c764.fc20.noarch.rpm
golang-github-mitchellh-mapstructure.spec
golang-github-mitchellh-mapstructure.src: W: spelling-error %description -l
en_US versa -> avers, verse, verso
golang-github-mitchellh-mapstructure-devel.noarch: W: spelling-error
%description -l en_US versa -> avers, verse, verso
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8 years
[Bug 1318358] New: Review Request: copr-dist-git - Copr services for Dist Git server
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1318358
Bug ID: 1318358
Summary: Review Request: copr-dist-git - Copr services for Dist
Git server
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: msuchy(a)redhat.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL: http://miroslav.suchy.cz/copr/copr-dist-git.spec
SRPM URL: http://miroslav.suchy.cz/copr/copr-dist-git-0.14-1.fc23.src.rpm
Description: COPR is lightweight build system. It allows you to create new
project in WebUI
and submit new builds and COPR will create yum repository from latest builds.
This package contains Copr services for Dist Git server.
Fedora Account System Username: msuchy
rpmlint waives off:
copr-dist-git.noarch: W: non-standard-uid /var/lib/copr-dist-git copr-service
copr-dist-git.noarch: W: non-standard-gid /var/lib/copr-dist-git copr-service
copr-dist-git.noarch: W: non-standard-uid /var/log/copr-dist-git copr-service
copr-dist-git.noarch: W: non-standard-gid /var/log/copr-dist-git copr-service
copr-dist-git.noarch: W: non-standard-uid /var/log/copr-dist-git/main.log
copr-service
copr-dist-git.noarch: W: non-standard-gid /var/log/copr-dist-git/main.log
copr-service
copr-dist-git.noarch: W: non-standard-gid /etc/copr/copr-dist-git.conf
copr-service
It must be writeable by service which use identity copr-service:copr-service
copr-dist-git.noarch: E: non-readable /etc/copr/copr-dist-git.conf 640
There are confidental data.
copr-dist-git.noarch: W: no-manual-page-for-binary importer_runner.py
copr-dist-git.noarch: W: no-documentation
This is for internal Copr instance. Not actually meant to be run and
installed without additional knowledge. Whole setup is documented on project
page.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8 years
[Bug 1298019] New: Review Request: nvme-cli - NVMe management command line interface
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1298019
Bug ID: 1298019
Summary: Review Request: nvme-cli - NVMe management command
line interface
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: luto(a)kernel.org
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL: http://web.mit.edu/luto/www/fedora/nvme-cli-v1/nvme-cli.spec
SRPM URL:
http://web.mit.edu/luto/www/fedora/nvme-cli-v1/nvme-cli-0.2-1.20160112git...
Description: nvme-cli provides NVM-Express user space tooling for Linux.
Fedora Account System Username: amluto
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=12523790
Self-review: (NB: checksums are off because I fixed a trivial bug after
generating this, and I didn't want to wait for fedora-review to run again.)
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v2 or later)", "Unknown or generated". 130 files have
unknown license. Detailed output of licensecheck in
/home/luto/devel/fedora/nvme-cli/nvme-cli/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in nvme-
cli-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
Rpmlint
-------
Checking: nvme-cli-0.2-1.20160112gitde3e0f1.fc21.x86_64.rpm
nvme-cli-debuginfo-0.2-1.20160112gitde3e0f1.fc21.x86_64.rpm
nvme-cli-0.2-1.20160112gitde3e0f1.fc21.src.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (debuginfo)
-------------------
Checking: nvme-cli-debuginfo-0.2-1.20160112gitde3e0f1.fc21.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages)
----------------------------
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Requires
--------
nvme-cli (rpmlib, GLIBC filtered):
libc.so.6()(64bit)
rtld(GNU_HASH)
nvme-cli-debuginfo (rpmlib, GLIBC filtered):
Provides
--------
nvme-cli:
nvme-cli
nvme-cli(x86-64)
nvme-cli-debuginfo:
nvme-cli-debuginfo
nvme-cli-debuginfo(x86-64)
Source checksums
----------------
https://github.com/linux-nvme/nvme-cli/archive/de3e0f1477d30fe3ece68de9a3...
:
CHECKSUM(SHA256) this package :
cc5afb51aa6d6d5cc49f1e0c41585adc2aa1e458c2cb5e930a4ab276b6a488a4
CHECKSUM(SHA256) upstream package :
cc5afb51aa6d6d5cc49f1e0c41585adc2aa1e458c2cb5e930a4ab276b6a488a4
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -rn
nvme-cli-0.2-1.20160112gitde3e0f1.fc23.src.rpm
Buildroot used: fedora-21-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8 years