[Bug 1391598] New: Review Request: mkosi - Create legacy-free OS
images
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1391598
Bug ID: 1391598
Summary: Review Request: mkosi - Create legacy-free OS images
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: zbyszek(a)in.waw.pl
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL: http://in.waw.pl/~zbyszek/fedora/mkosi.spec
SRPM URL: http://in.waw.pl/~zbyszek/fedora/mkosi-1-1.fc26.src.rpm
Fedora Account System Username: zbyszek
Description:
A fancy wrapper around "dnf --installroot", "debootstrap" and
"pacstrap", that may generate disk images with a number of bells and
whistles.
Generated images are "legacy-free". This means only GPT disk labels
(and no MBR disk labels) are supported, and only systemd based images
may be generated. Moreover, for bootable images only EFI systems are
supported (not plain MBR/BIOS).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7 years, 6 months
[Bug 1367536] New: Rebase clufter component
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1367536
Bug ID: 1367536
Summary: Rebase clufter component
Product: Red Hat Enterprise Linux 6
Version: 6.5
Component: clufter
Keywords: Rebase
Severity: medium
Priority: high
Assignee: jpokorny(a)redhat.com
Reporter: jpokorny(a)redhat.com
QA Contact: cluster-qe(a)redhat.com
CC: borgan(a)redhat.com, cfeist(a)redhat.com,
cluster-qe(a)redhat.com, extras-qa(a)fedoraproject.org,
jpokorny(a)redhat.com, lkocman(a)redhat.com,
lkuprova(a)redhat.com, mlisik(a)redhat.com,
nobody(a)fedoraproject.org,
package-review(a)lists.fedoraproject.org,
phagara(a)redhat.com, royoung(a)redhat.com,
rsteiger(a)redhat.com, rwilliam(a)redhat.com,
salmy(a)redhat.com, slevine(a)redhat.com,
tlavigne(a)redhat.com, vpavlin(a)redhat.com
Depends On: 1343661
Blocks: 1328078
+++ This bug was initially created as a clone of Bug #1343661 +++
+++ This bug was initially created as a clone of Bug #1269964 +++
Upstream development of clufter has progressed (since 6.8 package
till 6.9 package + something more likely to come) so this asks for
a rebase.
More specifically, clufter received plentiful bug fixes and enhancements
compared to previous RHEL minor release (6.8/clufter-0.56.2),
notably commits in 0.56.3:
filters/coro2pcscmd[cluster,corosync]: make pcs --wait check silent
filters/configuration[cib2pcscmd]: avoid "pcs cluster cib <file> --config"
both of which are relevant to [bug 1328078].
... plus ...
v0.57.0
- bug fixes:
. with *2pcscmd* commands, clufter would previously emit doubled
"pcs" at the beginning for the command defining simple order
constraint
. with *2pcscmd* commands, clufter would previously omit and/or
logic operators between each pair of atomic expressions
forming a rule for location constraint
. with *2pcscmd* commands, clufter would previously disregard
master/slave roles correctly encoded with a capitalized first
letter in CIB for colocation and location constraints
- feature extensions:
. with *2pcscmd* commands, clufter now supports resource sets
for colocation and order constraints
. with *2pcscmd* commands, clufter now supports ticket contraints
(incl. resource sets)
v0.58.0
- bug fixes:
. the upstream-suggested (meta) specfile and its form of advising
how to run Python intepreter (added with previous release)
turned to cause issues if setuptools are not recent enough,
so double-check that no extra double-quoting is injected
in any case
[https://github.com/pypa/setuptools/issues/188]
. some internal-only negligence was fixed to match the design
intentions (may affect too relaxed 3rd party plugins)
- feature extensions:
. pcs2pcscmd* commands are now aware of quorum device configured
in corosync.conf and are able to emit respective configuration
commands using pcs tool
v0.59.0
- bug fixes:
. previously, pcs2pcscmd* commands would attempt to have quorum
device configured using "pcs quorum add" whereas the correct syntax
is "pcs quorum device add"
. with {cib,pcs}2pcscmd* commands, clufter no longer chokes on
validation failures (unless --nocheck provided) due to source CIB
file using newer "validate-with" validation version specification
than supported so far, such as with pacemaker-2.5 introducing the
alert handlers stanza in CIB, because the support has been extended
up that very version (only affects deployments that do not borrow
the schemas from the installed pacemaker on-the-fly during a build
stage, which is not the case when building RPMs using the upstream
specfile)
- feature extensions:
. {cib,pcs}2pcscmd* commands are now aware of configured alert
handlers in CIB and able to emit respective configuration
commands using pcs tool
- functional changes:
. due to too many moving targets (corosync, pacemaker, pcs) with
features being gradually added, clufter as of this release
relies on the specified distribution target (which basically boils
down to snapshot of the supported features, as opposed to passing
zillion extra parameters expressing the same) stronger than ever;
this has several implications: do not expect that one sequence
of pcs commands at the clufter's output is portable to completely
different environment, and your distribution/setup may not be
supported (I try to cover Fedora, RHEL+derivates, Debian and Ubuntu
directly) in which case facts.py (where everything is tracked)
needs to be patched
v0.59.1
- bug fixes:
. internal: facts.infer_dist('*') results would previously diverge
from results for a specific query
. X.04 Ubuntu's versioning fanciness is now ditched in favor of
canonical (sic) X.4 versioning; this was not a buggy behavior
per se, but internally, 04 used to be parsed as octal literal
which would go bananas with expressions like '08';
to maintain compatibility, respective string-held X.04 aliases
were introduced, though
- feature extensions:
. there is now --list-dists option to clufter that is intended
mainly to suggest as to which --dist option values (note this
has an increased importance, at least as of the previous
release) are supporte
- internal enhancements:
decisions about the parameters to feed XSLT processing proper
v0.59.2
- feature extensions:
. *2pcscmd commands now first emit a comment block containing key
pieces of information about the run, such as a current date,
library version, the overall command that was executed, and
importantly (more and more), the target system specification
(this utilizes a new, dedicated cmd-annotate filter)
- internal enhancements:
. so far, all formats used to represent concrete information
representable in various pertaining forms; generator type
of filters (such as mentioned cmd-annotate) imposed the
existence of a special "empty" format (analogous to "void"
in C) for generators to map from into something useful,
so this release introduces "Nothing" format and makes sure
it's generally usable throughout the internals just as well
v0.59.3
- feature extensions:
. *2pcscmd commands will now colorize the output (very plain support,
more to be expected) if either a terminal is used as a sink (and
colors not explicitly forbidden) or if this is enforced; so far
only shell comments and some parts of pcs syntax are supported,
but even in this form, it should help users to wrap their heads
(eyes) around what can be considered quite a complex output
from the first sight
v0.59.4
- feature extensions:
. when *2pcscmd commands colorize the output, upcoming booth-related
pcs commands are considered as well
- bug fixes:
. {ccs,pcs}2pcscmd* would previously exceed a recursion limit due
to not catching the bottom of the recursion properly
. with *2pcscmd* commands, --dump=cmd-annotate switch would
previously cause troubles as newly introduced Nothing format
lacked "hash" property (which is used to construct reasonably
unique file name to store the intermediate result at individual
phases of the filter-piping process)
v0.59.5
- feature extensions:
. when *2pcscmd or cmd-wrap commands colorize the output, "meta"
words for the shell are distinguished as well (related to the
first bug that this very handling also helped in nailing down)
- bug fixes:
. {ccs,pcs}2pcscmd* commands would previously emit an incorrectly
quoted command (in the self-check the following sequence of
commands is indeed being run on the to-be-clustered machine)
unless -g or --noguidance option was used;
in turn the respective internals received a considerable
overhaul to be able to cope with nested commands
(command/process substitution) better;
for users of previous releases, the remedy is to use this -g switch
or to pass --noop=cmd-wrap to suppress the faulty filter from
the pipeline (at the expense of not-so-easy-to-consume output)
. *2pcscmd* commands would previously omit colorizing some parts
of pcs syntax, contrary to the predestined expectations; e.g.:
pcs -f tmp-cib.xml constraint colocation SERVICE-foo rule ...
^^^^^^^^^^^^^^^^^^^^^
(see also https://pagure.io/clufter/releases)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1328078
[Bug 1328078] *2pcscmd commands ought not to suggest "pcs cluster cib
<file> --config" that doesn't currently work for subsequent
local-modification pcs commands
https://bugzilla.redhat.com/show_bug.cgi?id=1343661
[Bug 1343661] Rebase clufter component
--
You are receiving this mail because:
You are on the CC list for the bug.
7 years, 6 months
[Bug 1391291] New: Review Request:
perl-DBICx-AutoDoc - Generate automatic documentation of DBIx::Class::
Schema objects
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1391291
Bug ID: 1391291
Summary: Review Request: perl-DBICx-AutoDoc - Generate
automatic documentation of DBIx::Class::Schema objects
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: emmanuel(a)seyman.fr
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL:
http://people.parinux.org/~seyman/fedora/perl-DBICx-AutoDoc/perl-DBICx-Au...
SRPM URL:
http://people.parinux.org/~seyman/fedora/perl-DBICx-AutoDoc/perl-DBICx-Au...
Description:
DBICx::AutoDoc is a utility that can automatically generate documentation
for your DBIx::Class schemas. It works by collecting information from
several sources and arranging it into a format that makes it easier to deal
with from templates.
Fedora Account System Username: eseyman
Rpmlint Output:
perl-DBICx-AutoDoc.noarch: W: spelling-error %description -l en_US schemas ->
schema, sachems, schemes
perl-DBICx-AutoDoc.noarch: E: wrong-script-interpreter
/usr/share/perl5/vendor_perl/auto/share/dist/DBICx-AutoDoc/AUTODOC-graph.png [%
ENV.SHELL %]
perl-DBICx-AutoDoc.noarch: E: non-executable-script
/usr/share/perl5/vendor_perl/auto/share/dist/DBICx-AutoDoc/AUTODOC-graph.png
644 [% ENV.SHELL %]
perl-DBICx-AutoDoc.noarch: E: non-executable-script
/usr/share/perl5/vendor_perl/auto/share/dist/DBICx-AutoDoc/AUTODOC-inheritance.html
644 /usr/bin/perl
perl-DBICx-AutoDoc.noarch: E: wrong-script-interpreter
/usr/share/perl5/vendor_perl/auto/share/dist/DBICx-AutoDoc/AUTODOC-inheritance.png
[% ENV.SHELL %]
perl-DBICx-AutoDoc.noarch: E: non-executable-script
/usr/share/perl5/vendor_perl/auto/share/dist/DBICx-AutoDoc/AUTODOC-inheritance.png
644 [% ENV.SHELL %]
perl-DBICx-AutoDoc.noarch: E: non-executable-script
/usr/share/perl5/vendor_perl/auto/share/dist/DBICx-AutoDoc/AUTODOC-graph.html
644 /usr/bin/perl
perl-DBICx-AutoDoc.src: W: spelling-error %description -l en_US schemas ->
schema, sachems, schemes
2 packages and 1 specfiles checked; 6 errors, 2 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7 years, 6 months
[Bug 1390063] Package Review:
classloader-leak-test-framework - Detection and verification of Java
ClassLoader leaks
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1390063
--- Comment #5 from Pavel Raiskup <praiskup(a)redhat.com> ---
missing java checks:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It
is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Maven:
[x]: If package contains pom.xml files install it (including metadata) even
when building with ant
praiskup: installed as classloader-leak-test-framework.pom, IIUC
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7 years, 6 months
[Bug 1390063] Package Review:
classloader-leak-test-framework - Detection and verification of Java
ClassLoader leaks
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1390063
Pavel Raiskup <praiskup(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #4 from Pavel Raiskup <praiskup(a)redhat.com> ---
APPROVED, thanks! One minor nit, please wrap the long line in %description.
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- This seems like a Java package, please install fedora-review-plugin-java
to get additional checks
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 28 files have unknown license. Detailed
output of licensecheck in /home/praiskup/packages/classloader-leak-
test-framework/review/1390063-classloader-leak-test-
framework/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/licenses, /usr/share/maven-metadata
praiskup: filesystem/javapackages tools
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/javadoc, /usr,
/usr/share/licenses, /usr/share/maven-metadata, /usr/share/java,
/usr/share, /usr/share/doc, /usr/share/maven-poms
praiskup: I'm not sure what's going on here. OTOH, being that a java package
we
have less control over file lists ('-f .mfiles' is used).
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
classloader-leak-test-framework-javadoc
praiskup: I geuss this is OK, because that's generated dep.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
praiskup: maven automatically runs testsuite
[-]: Packages should try to preserve timestamps of original installed
files.
praiskup: %maven_install used
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: classloader-leak-test-framework-1.1.1-1.fc26.noarch.rpm
classloader-leak-test-framework-javadoc-1.1.1-1.fc26.noarch.rpm
classloader-leak-test-framework-1.1.1-1.fc26.src.rpm
classloader-leak-test-framework.noarch: E: description-line-too-long C
Stand-alone test framework for detecting and/or verifying the existence or
non-existence of Java ClassLoader leaks. It is also possible to test leak
prevention mechanisms to confirm that the leak really is avoided. The framework
is an built upon JUnit.
classloader-leak-test-framework.src: E: description-line-too-long C Stand-alone
test framework for detecting and/or verifying the existence or non-existence of
Java ClassLoader leaks. It is also possible to test leak prevention mechanisms
to confirm that the leak really is avoided. The framework is an built upon
JUnit.
classloader-leak-test-framework.src:10: W: macro-in-comment %{name}
classloader-leak-test-framework.src:10: W: macro-in-comment %{version}
3 packages and 0 specfiles checked; 2 errors, 2 warnings.
Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:
Requires
--------
classloader-leak-test-framework (rpmlib, GLIBC filtered):
java-headless
javapackages-tools
mvn(junit:junit)
mvn(org.apache.bcel:bcel)
classloader-leak-test-framework-javadoc (rpmlib, GLIBC filtered):
javapackages-tools
Provides
--------
classloader-leak-test-framework:
classloader-leak-test-framework
mvn(se.jiderhamn:classloader-leak-test-framework)
mvn(se.jiderhamn:classloader-leak-test-framework:pom:)
classloader-leak-test-framework-javadoc:
classloader-leak-test-framework-javadoc
Source checksums
----------------
https://github.com/mjiderhamn/classloader-leak-prevention/archive/classlo...
:
CHECKSUM(SHA256) this package :
ba47c6312d49e662d55988eea1ef5686ba0903722cc456fa080973fead45c997
CHECKSUM(SHA256) upstream package :
ba47c6312d49e662d55988eea1ef5686ba0903722cc456fa080973fead45c997
Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
Command line :/bin/fedora-review -b 1390063 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, Java
Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7 years, 6 months