[Bug 1172603] New: Review Request: golang-github-ghodss-yaml - A better way to marshal and unmarshal YAML in Golang
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1172603
Bug ID: 1172603
Summary: Review Request: golang-github-ghodss-yaml - A better
way to marshal and unmarshal YAML in Golang
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: jchaloup(a)redhat.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL:
https://jchaloup.fedorapeople.org/reviews/golang-github-ghodss-yaml/golan...
SRPM URL:
https://jchaloup.fedorapeople.org/reviews/golang-github-ghodss-yaml/golan...
Description: A better way to marshal and unmarshal YAML in Golang
Fedora Account System Username: jchaloup
Koji: buildroot-override not working right know to use the yaml/v2 but locally
building successfully.
$ rpmlint golang-github-ghodss-yaml-0-0.1.git92ff9d3.fc20.src.rpm
golang-github-ghodss-yaml-devel-0-0.1.git92ff9d3.fc20.noarch.rpm
golang-github-ghodss-yaml.spec
golang-github-ghodss-yaml.src: W: spelling-error Summary(en_US) unmarshal ->
Marshall, marshal
golang-github-ghodss-yaml.src: W: spelling-error %description -l en_US
unmarshal -> Marshall, marshal
golang-github-ghodss-yaml-devel.noarch: W: spelling-error Summary(en_US)
unmarshal -> Marshall, marshal
golang-github-ghodss-yaml-devel.noarch: W: spelling-error %description -l en_US
unmarshal -> Marshall, marshal
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8 years, 9 months
[Bug 673585] Review Request: perl-Apache-Htgroup - Manage Apache htgroup files
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=673585
--- Comment #15 from Parag AN(पराग) <panemade(a)gmail.com> ---
Here is my review for your -3 release srpm
1)I see you have used Buildroot tag which is also become optional and not
needed. Can you remove it and upload again spec and srpm? No need to bump the
release tag. Also, fedora-review output review.txt showed mismatch of spec
given by spec url and spec file inside srpm as
Diff spec file in url and in SRPM
---------------------------------
--- /home/parag/673585-perl-Apache-Htgroup/srpm/perl-Apache-Htgroup.spec
2015-08-18 21:51:58.536356400 +0530
+++
/home/parag/673585-perl-Apache-Htgroup/srpm-unpacked/perl-Apache-Htgroup.spec
2015-08-18 20:38:27.000000000 +0530
@@ -35,6 +35,6 @@
%files
-%doc README
%license LICENSE
+%doc README
%{perl_vendorlib}/*
%{_mandir}/man3/*
@@ -42,5 +42,5 @@
%changelog
* Tue Aug 18 2015 Steven Hadfield <hadfieldster(a)gmail.com> 1.23-3
-- RPM spec cleanup
+- RPM spec fixes
* Fri Jul 6 2012 Steven Hadfield <StevenHadfield(a)letu.edu> 1.23-2
2) It is okay if there is no response from upstream on fixing fsf address
issue.
3) Start reviewing other people's packages and once you did full package review
like I did for you in comment#11 here, post that review link in this bugzilla
to let me know that you are reviewing and your reviews are good where you have
pointed some issues with how to fix them.
--
You are receiving this mail because:
You are always notified about changes to this product and component
8 years, 9 months