[Bug 226324] Merge Review: psutils
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=226324
--- Comment #16 from Ralf Corsepius <rc040203(a)freenet.de> ---
Another remark:
What is the reason for the the -*perl vs. <main> split?
/usr/bin/psjoin is a perl-script and is part of the <main> package, and is not
part of the *-perl sub-package.
It's at least one reason for the main package to pull-in perl and several perl
modules, which means having a *-perl subpackage is rather pointless
dependency-wise:
# rpm -q --requires -p
results_psutils/1.23/2.fc21/psutils-1.23-2.fc21.x86_64.rpm
...
perl(Getopt::Long)
perl(strict)
perl(warnings)
...
# rpm -q --requires -p results_psutils/1.23/2.fc21/psutils-
...
perl-1.23-2.fc21.noarch.rpm
/usr/bin/env
perl
perl(File::Basename)
perl(Getopt::Long)
perl(strict)
perl(warnings)
...
--
You are receiving this mail because:
You are always notified about changes to this product and component
10 years, 1 month
[Bug 226324] Merge Review: psutils
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=226324
Ralf Corsepius <rc040203(a)freenet.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rc040203(a)freenet.de
--- Comment #15 from Ralf Corsepius <rc040203(a)freenet.de> ---
Some remarks from the perspective of a perl-packager:
* These 2 "#!/usr/bin/env perl" need to be replaced with %{__perl}
(/usr/bin/perl) in %prep or %build:
psutils-1.23/extractres:#!/usr/bin/env perl
psutils-1.23/psjoin:#!/usr/bin/env perl
* These BRs: are missing:
BR: perl(File::Basename)
BR: perl(Getopt::Long)
BR: perl(strict)
BR: perl(warnings)
--
You are receiving this mail because:
You are always notified about changes to this product and component
10 years, 1 month
[Bug 226493] Merge Review: tix
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=226493
José Matos <jamatos(a)fc.up.pt> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |CLOSED
Resolution|--- |RAWHIDE
Last Closed| |2014-04-01 12:42:46
--- Comment #8 from José Matos <jamatos(a)fc.up.pt> ---
Pong.
I have been busy with two lovely kids in between. :-)
The package is approved. There are small warnings like the man pages macros not
defined or the bogus dates on the spec file but those are minor.
So tix is approved. Hurray. :-)
--
You are receiving this mail because:
You are always notified about changes to this product and component
10 years, 1 month
[Bug 226324] Merge Review: psutils
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=226324
Dan Horák <dhorak(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dhorak(a)redhat.com
--- Comment #14 from Dan Horák <dhorak(a)redhat.com> ---
before we close this old merge review, I think there are 2 issues that should
be resolved:
- you should use the wildcard style for man pages in %files, instead of
%{_mandir}/man1/epsffit.1.gz use %{_mandir}/man1/epsffit.1*, the compression is
done by rpmbuild itself and when the algorithm changes, the spec file won't
require a change
- I don't think is is necessary to hard Require: perl in the perl subpackage,
perl (the interpreter) will be brought in with the automagically added
dependencies
--
You are receiving this mail because:
You are always notified about changes to this product and component
10 years, 1 month